rewrite Align::max_for_target in a more obvious way#158867
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Member
|
Sure! @bors r+ rollup=always (As you say, it only impacts 16-bit so it'd be hard to even notice if it was wrong.) |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 6, 2026
rewrite `Align::max_for_target` in a more obvious way r? scottmcm The old version was just as correct, and arguably this doesn't matter, but oh well... Following the confusion in https://github.com/rust-lang/rust/pull/152929/changes#r2836568710.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 7, 2026
Rollup of 13 pull requests Successful merges: - #158478 (Use correct typing mode in mir building for the next solver) - #158796 (Distinguish null reference production from null pointer dereference in UB checks) - #158821 (add regression test for late-bound type method probe ICE) - #158245 (Update the rustc_perf submodule) - #158346 (Prevent rustdoc auto-trait ICEs with `-Znext-solver=globally`) - #158536 (Instatiate binder instead of skipping when suggesting function arg error) - #158553 (Avoid infinite recursion when trying to build valtrees for self-referential consts) - #158679 (Document blocking guarantees for `std::sync`) - #158826 (Reorganize `tests/ui/issues` [19/N]) - #158860 (Delete `impl_def_id` field from `ImplHeader`) - #158867 (rewrite `Align::max_for_target` in a more obvious way) - #158878 (borrowck: Inline `free_region_constraint_info()` to simplify the code) - #158881 (Update mdbook to 0.5.4)
rust-timer
added a commit
that referenced
this pull request
Jul 7, 2026
Rollup merge of #158867 - WaffleLapkin:driveby, r=scottmcm rewrite `Align::max_for_target` in a more obvious way r? scottmcm The old version was just as correct, and arguably this doesn't matter, but oh well... Following the confusion in https://github.com/rust-lang/rust/pull/152929/changes#r2836568710.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? scottmcm
The old version was just as correct, and arguably this doesn't matter, but oh well...
Following the confusion in https://github.com/rust-lang/rust/pull/152929/changes#r2836568710.