Fix the span for parameter suggestion by chenyukang · Pull Request #158862 · rust-lang/rust

chenyukang · 2026-07-06T14:59:07Z

Previously, the recovered parameter span could point only at the inner identifier, so the suggestion was inserted after the leading &, produced a werid &&self.

The fix keeps the recovered parameter's full span on Param.span

r? @nnethercote

the second commit shows the diff of stderr.

rustbot · 2026-07-06T14:59:10Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Unique-Usman · 2026-07-06T18:32:46Z

+   |
+help: add a `self` receiver parameter to make the associated `fn` a method
+   |
+LL |     fn some_fn(&self, &some_name) {


This pr also seems to work for similar case like,

impl Foo { fn some_fn(mut some_name) { self } }

impl Foo { fn some_fn(String s) { self } }

maybe we might want to add them as test,

also the suggest function signature seems to be malformed -> fn some_fn(&self, &some_name)

View changes since the review

the suggest function signature seems to be malformed -> fn some_fn(&self, &some_name)

you means it's better to suggest fn some_fn(&self, some_name: &TypeName)?
this seems the best, but currently adding type for a parameter is a different suggestion created by different code.

there is a suggestion above to add a type:

help: if this is a parameter name, give it a type | LL - fn some_fn(&some_name) { LL + fn some_fn(some_name: &TypeName) {

nnethercote · 2026-07-08T08:05:34Z

@bors r+ rollup

rust-bors · 2026-07-08T08:05:37Z

📌 Commit 14bb27e has been approved by nnethercote

It is now in the queue for this repository.

@nnethercote

…receiver-suggestion, r=nnethercote Fix the span for parameter suggestion Fixes rust-lang#131084 Previously, the recovered parameter span could point only at the inner identifier, so the suggestion was inserted after the leading `&`, produced a werid `&&self`. The fix keeps the recovered parameter's full span on `Param.span` r? @nnethercote the second commit shows the diff of stderr.

@nnethercote

…receiver-suggestion, r=nnethercote Fix the span for parameter suggestion Fixes rust-lang#131084 Previously, the recovered parameter span could point only at the inner identifier, so the suggestion was inserted after the leading `&`, produced a werid `&&self`. The fix keeps the recovered parameter's full span on `Param.span` r? @nnethercote the second commit shows the diff of stderr.

…uwer Rollup of 18 pull requests Successful merges: - #158871 (add relnotes for 1.97.0) - #150946 (intrinsics: Add a fallback for non-const libm float functions) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158655 (Fix coroutine MIR saved local remapping) - #158666 (Carry the `b_offset` inside `BackendRepr::ScalarPair`) - #158920 (Update wasm-component-ld to 0.5.26) - #158926 (wrapping_sh* methods: clarify underspecified reference) - #158927 (add core test run with `-Zforce-intrinsic-fallback`) - #151379 (Stabilize `VecDeque::retain_back` from `truncate_front`) - #158807 (Add regression test for CString::clone_into unwind safety) - #158862 (Fix the span for parameter suggestion ) - #158883 (tests: fix enum-match.rs to handle LLVM 23) - #158894 (Make the ordering of non-terminal binds in ambiguity error messages deterministic) - #158902 (add codegen test for range length bound propagation) - #158913 (Update `browser-ui-test` version to `0.24.1`) - #158935 (std: support real fd methods on Emscripten) - #158951 (Merge three `MaxUniverse`s into one)

@nnethercote

…receiver-suggestion, r=nnethercote Fix the span for parameter suggestion Fixes rust-lang#131084 Previously, the recovered parameter span could point only at the inner identifier, so the suggestion was inserted after the leading `&`, produced a werid `&&self`. The fix keeps the recovered parameter's full span on `Param.span` r? @nnethercote the second commit shows the diff of stderr.

@nnethercote

…receiver-suggestion, r=nnethercote Fix the span for parameter suggestion Fixes rust-lang#131084 Previously, the recovered parameter span could point only at the inner identifier, so the suggestion was inserted after the leading `&`, produced a werid `&&self`. The fix keeps the recovered parameter's full span on `Param.span` r? @nnethercote the second commit shows the diff of stderr.

…uwer Rollup of 25 pull requests Successful merges: - #158871 (add relnotes for 1.97.0) - #158968 (stdarch subtree update) - #154445 (rustdoc: Represent `--output-format=json` coverage and ir differently) - #156370 (Reject linked dylib EII default overrides) - #157153 (allow `Allocator`s to be used as `#[global_allocator]`s) - #158495 (Rename HAS_CT_PROJECTION to HAS_CONST_ALIAS) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158655 (Fix coroutine MIR saved local remapping) - #158666 (Carry the `b_offset` inside `BackendRepr::ScalarPair`) - #158912 (Introduce new bootstrap config section for PGO configuration) - #158920 (Update wasm-component-ld to 0.5.26) - #158926 (wrapping_sh* methods: clarify underspecified reference) - #158927 (add core test run with `-Zforce-intrinsic-fallback`) - #158932 (Do not build the compiler when invoking `x perf compare`) - #158937 (Emit the emscripten entry point as `__main_argc_argv`) - #151379 (Stabilize `VecDeque::retain_back` from `truncate_front`) - #156548 ( Library support for aarch64-unknown-linux-pauthtest target) - #158307 (CI job for parallel frontend ui tests) - #158347 (Improve generic parameters handling for #[diagnostic::on_const]) - #158722 (delegation: do not always inherit `ConstArgHasType` predicates) - #158741 (Simplify `Option::into_flat_iter` signature) - #158807 (Add regression test for CString::clone_into unwind safety) - #158862 (Fix the span for parameter suggestion ) - #158883 (tests: fix enum-match.rs to handle LLVM 23)

@nnethercote

…receiver-suggestion, r=nnethercote Fix the span for parameter suggestion Fixes rust-lang#131084 Previously, the recovered parameter span could point only at the inner identifier, so the suggestion was inserted after the leading `&`, produced a werid `&&self`. The fix keeps the recovered parameter's full span on `Param.span` r? @nnethercote the second commit shows the diff of stderr.

Rollup of 23 pull requests Successful merges: - #158968 (stdarch subtree update) - #154445 (rustdoc: Represent `--output-format=json` coverage and ir differently) - #158495 (Rename HAS_CT_PROJECTION to HAS_CONST_ALIAS) - #158666 (Carry the `b_offset` inside `BackendRepr::ScalarPair`) - #158870 (std: merge the unix-like io::error modules into one file) - #158920 (Update wasm-component-ld to 0.5.26) - #158926 (wrapping_sh* methods: clarify underspecified reference) - #158927 (add core test run with `-Zforce-intrinsic-fallback`) - #158932 (Do not build the compiler when invoking `x perf compare`) - #158937 (Emit the emscripten entry point as `__main_argc_argv`) - #151379 (Stabilize `VecDeque::retain_back` from `truncate_front`) - #156144 (Better docs for PartialEq (includes macro rename)) - #156548 ( Library support for aarch64-unknown-linux-pauthtest target) - #157995 (`Vec::dedup_by` docs explicit function argument order) - #158307 (CI job for parallel frontend ui tests) - #158741 (Simplify `Option::into_flat_iter` signature) - #158807 (Add regression test for CString::clone_into unwind safety) - #158862 (Fix the span for parameter suggestion ) - #158894 (Make the ordering of non-terminal binds in ambiguity error messages deterministic) - #158902 (add codegen test for range length bound propagation) - #158913 (Update `browser-ui-test` version to `0.24.1`) - #158935 (std: support real fd methods on Emscripten) - #158978 (Add regression test for too-big by-value ABI args)

@nnethercote

Rollup merge of #158862 - chenyukang:yukang-fix-131084-self-receiver-suggestion, r=nnethercote Fix the span for parameter suggestion Fixes #131084 Previously, the recovered parameter span could point only at the inner identifier, so the suggestion was inserted after the leading `&`, produced a werid `&&self`. The fix keeps the recovered parameter's full span on `Param.span` r? @nnethercote the second commit shows the diff of stderr.

Rollup of 23 pull requests Successful merges: - rust-lang/rust#158968 (stdarch subtree update) - rust-lang/rust#154445 (rustdoc: Represent `--output-format=json` coverage and ir differently) - rust-lang/rust#158495 (Rename HAS_CT_PROJECTION to HAS_CONST_ALIAS) - rust-lang/rust#158666 (Carry the `b_offset` inside `BackendRepr::ScalarPair`) - rust-lang/rust#158870 (std: merge the unix-like io::error modules into one file) - rust-lang/rust#158920 (Update wasm-component-ld to 0.5.26) - rust-lang/rust#158926 (wrapping_sh* methods: clarify underspecified reference) - rust-lang/rust#158927 (add core test run with `-Zforce-intrinsic-fallback`) - rust-lang/rust#158932 (Do not build the compiler when invoking `x perf compare`) - rust-lang/rust#158937 (Emit the emscripten entry point as `__main_argc_argv`) - rust-lang/rust#151379 (Stabilize `VecDeque::retain_back` from `truncate_front`) - rust-lang/rust#156144 (Better docs for PartialEq (includes macro rename)) - rust-lang/rust#156548 ( Library support for aarch64-unknown-linux-pauthtest target) - rust-lang/rust#157995 (`Vec::dedup_by` docs explicit function argument order) - rust-lang/rust#158307 (CI job for parallel frontend ui tests) - rust-lang/rust#158741 (Simplify `Option::into_flat_iter` signature) - rust-lang/rust#158807 (Add regression test for CString::clone_into unwind safety) - rust-lang/rust#158862 (Fix the span for parameter suggestion ) - rust-lang/rust#158894 (Make the ordering of non-terminal binds in ambiguity error messages deterministic) - rust-lang/rust#158902 (add codegen test for range length bound propagation) - rust-lang/rust#158913 (Update `browser-ui-test` version to `0.24.1`) - rust-lang/rust#158935 (std: support real fd methods on Emscripten) - rust-lang/rust#158978 (Add regression test for too-big by-value ABI args)

chenyukang added 2 commits July 6, 2026 22:53

add test for wrong suggest of self receiver

c7eb5e4

correct the span for parameter suggestion

d09f7ca

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 6, 2026

rustbot assigned nnethercote Jul 6, 2026

Unique-Usman reviewed Jul 6, 2026

View reviewed changes

add more tests for suggesting fn parameters

14bb27e

nnethercote approved these changes Jul 8, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2026

GuillaumeGomez mentioned this pull request Jul 8, 2026

Rollup of 16 pull requests #158953

Closed

JonathanBrouwer mentioned this pull request Jul 8, 2026

Rollup of 18 pull requests #158958

Closed

JonathanBrouwer mentioned this pull request Jul 8, 2026

Rollup of 25 pull requests #158973

Closed

JonathanBrouwer mentioned this pull request Jul 8, 2026

Rollup of 25 pull requests #158977

Closed

This was referenced Jul 9, 2026

Rollup of 25 pull requests #158989

Closed

Rollup of 23 pull requests #158991

Merged

rust-bors Bot merged commit ee0bd19 into rust-lang:main Jul 9, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Jul 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix the span for parameter suggestion #158862

Fix the span for parameter suggestion #158862
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
chenyukang:yukang-fix-131084-self-receiver-suggestion

chenyukang commented Jul 6, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

Unique-Usman Jul 6, 2026 •

edited by rustbot

Loading

Uh oh!

chenyukang Jul 7, 2026

Uh oh!

nnethercote commented Jul 8, 2026

Uh oh!

rust-bors Bot commented Jul 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

chenyukang commented Jul 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

Unique-Usman Jul 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chenyukang Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

nnethercote commented Jul 8, 2026

Uh oh!

rust-bors Bot commented Jul 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chenyukang commented Jul 6, 2026 •

edited by rustbot

Loading

Unique-Usman Jul 6, 2026 •

edited by rustbot

Loading