Skip to content

Fix rustdoc ICE on deprecated note in inlined re-export chain#158820

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
TaKO8Ki:fix-deprecated-note-reexport-chain
Jul 6, 2026
Merged

Fix rustdoc ICE on deprecated note in inlined re-export chain#158820
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
TaKO8Ki:fix-deprecated-note-reexport-chain

Conversation

@TaKO8Ki

@TaKO8Ki TaKO8Ki commented Jul 5, 2026

Copy link
Copy Markdown
Member

Fixes #158745

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 5, 2026
@rustbot

rustbot commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustdoc
  • rustdoc expanded to 8 candidates
  • Random selection from GuillaumeGomez, camelid, notriddle

@GuillaumeGomez

Copy link
Copy Markdown
Member

Looks good to me, thanks! Just gonna wait for #158751 to be merged first.

@TaKO8Ki

TaKO8Ki commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

r? GuillaumeGomez

Since the pr got merged, this pr is ready for merge?

@rustbot rustbot assigned GuillaumeGomez and unassigned notriddle Jul 6, 2026
@@ -0,0 +1,15 @@
//@ check-pass

@GuillaumeGomez GuillaumeGomez Jul 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention: please add a description of what this test is checking.

View changes since the review

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment.

@GuillaumeGomez

Copy link
Copy Markdown
Member

@bors squash

@rust-bors

This comment has been minimized.

* add regression test for deprecated note on inlined reexport chain
* resolve deprecated-note links from the owning reexport
* add a comment to regression test
@rust-bors

rust-bors Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🔨 3 commits were squashed into e7408fb.

@rust-bors rust-bors Bot force-pushed the fix-deprecated-note-reexport-chain branch from c952d72 to e7408fb Compare July 6, 2026 10:10
@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit e7408fb has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 6, 2026
…rt-chain, r=GuillaumeGomez

Fix rustdoc ICE on deprecated note in inlined re-export chain

Fixes rust-lang#158745
rust-bors Bot pushed a commit that referenced this pull request Jul 6, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #156976 (enable eager `param_env` norm in new solver)
 - #158537 (Add `std::io::cursor::WriteThroughCursor`)
 - #158540 (Move `std::io::Seek` to `core::io`)
 - #157820 (consider subtyping when checking if an infer var is sized)
 - #158505 (Update POSIX edition links)
 - #158853 (Fix typo for link on nto-qnx.md)
 - #157466 (Better error message when bare type in impl parameter list)
 - #157966 (Emit a suggestion to cast the never type into a concrete type when it fails to satisfy an `impl Trait` bound)
 - #158381 (Expose debug scope of statement and terminator in rustc_public)
 - #158405 (rustc_target: Add ARMv8-M related target features)
 - #158770 (Weaken guarantee for `From<legacy::RangeInclusive> for RangeInclusive`)
 - #158820 (Fix rustdoc ICE on deprecated note in inlined re-export chain)
@theemathas theemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 6, 2026
@rust-bors rust-bors Bot merged commit 68dfc1d into rust-lang:main Jul 6, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 6, 2026
rust-timer added a commit that referenced this pull request Jul 6, 2026
Rollup merge of #158820 - TaKO8Ki:fix-deprecated-note-reexport-chain, r=GuillaumeGomez

Fix rustdoc ICE on deprecated note in inlined re-export chain

Fixes #158745
@camelid camelid added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: no resolutions for a doc link

6 participants