Skip to content

Fix incorrect tracking issue for read_le/read_be#158757

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
kpeis695:fix/read-le-be-tracking-issue-link
Jul 6, 2026
Merged

Fix incorrect tracking issue for read_le/read_be#158757
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
kpeis695:fix/read-le-be-tracking-issue-link

Conversation

@kpeis695

@kpeis695 kpeis695 commented Jul 4, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

The #[unstable] attribute on Read::read_le and Read::read_be pointed to #156983, which is the implementation PR. The tracking issue is #156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion.

Closes #158721

@rustbot label +A-docs +T-libs-api

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 4, 2026
@rustbot

rustbot commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from 7 candidates

@rustbot rustbot added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 4, 2026
@rustbot

This comment has been minimized.

Sign in to view
@kpeis695 kpeis695 force-pushed the fix/read-le-be-tracking-issue-link branch from edb0697 to 81b7302 Compare July 4, 2026 02:42
@kpeis695
Fix incorrect tracking issue link for read_le/read_be
27935a6 
The unstable attribute on Read::read_le and Read::read_be pointed to
the implementation PR rather than the tracking issue, so the docs on
doc.rust-lang.org linked to the wrong page.
@kpeis695 kpeis695 force-pushed the fix/read-le-be-tracking-issue-link branch from 81b7302 to 27935a6 Compare July 4, 2026 02:47
JohnTitor
JohnTitor approved these changes Jul 4, 2026
View reviewed changes

@JohnTitor JohnTitor left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 27935a6 has been approved by JohnTitor

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 5, 2026
@jhpratt
Rollup merge of rust-lang#158757 - kpeis695:fix/read-le-be-tracking-i…
310b148 
…ssue-link, r=JohnTitor

Fix incorrect tracking issue for `read_le`/`read_be`

The `#[unstable]` attribute on `Read::read_le` and `Read::read_be` pointed to rust-lang#156983, which is the implementation PR. The tracking issue is rust-lang#156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion.

Closes rust-lang#158721

@rustbot label +A-docs +T-libs-api
@jhpratt jhpratt mentioned this pull request Jul 5, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 5, 2026
@jhpratt
Rollup merge of rust-lang#158757 - kpeis695:fix/read-le-be-tracking-i…
e14b2a7 
…ssue-link, r=JohnTitor

Fix incorrect tracking issue for `read_le`/`read_be`

The `#[unstable]` attribute on `Read::read_le` and `Read::read_be` pointed to rust-lang#156983, which is the implementation PR. The tracking issue is rust-lang#156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion.

Closes rust-lang#158721

@rustbot label +A-docs +T-libs-api
@jhpratt jhpratt mentioned this pull request Jul 5, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 5, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158757 - kpeis695:fix/read-le-be-tracking-i…
8914f81 
…ssue-link, r=JohnTitor

Fix incorrect tracking issue for `read_le`/`read_be`

The `#[unstable]` attribute on `Read::read_le` and `Read::read_be` pointed to rust-lang#156983, which is the implementation PR. The tracking issue is rust-lang#156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion.

Closes rust-lang#158721

@rustbot label +A-docs +T-libs-api
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 5, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 5, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158757 - kpeis695:fix/read-le-be-tracking-i…
50d354a 
…ssue-link, r=JohnTitor

Fix incorrect tracking issue for `read_le`/`read_be`

The `#[unstable]` attribute on `Read::read_le` and `Read::read_be` pointed to rust-lang#156983, which is the implementation PR. The tracking issue is rust-lang#156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion.

Closes rust-lang#158721

@rustbot label +A-docs +T-libs-api
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 5, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 5, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158757 - kpeis695:fix/read-le-be-tracking-i…
fcc9cf6 
…ssue-link, r=JohnTitor

Fix incorrect tracking issue for `read_le`/`read_be`

The `#[unstable]` attribute on `Read::read_le` and `Read::read_be` pointed to rust-lang#156983, which is the implementation PR. The tracking issue is rust-lang#156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion.

Closes rust-lang#158721

@rustbot label +A-docs +T-libs-api
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 5, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 6, 2026
@jhpratt
Rollup merge of rust-lang#158757 - kpeis695:fix/read-le-be-tracking-i…
ae2fff6 
…ssue-link, r=JohnTitor

Fix incorrect tracking issue for `read_le`/`read_be`

The `#[unstable]` attribute on `Read::read_le` and `Read::read_be` pointed to rust-lang#156983, which is the implementation PR. The tracking issue is rust-lang#156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion.

Closes rust-lang#158721

@rustbot label +A-docs +T-libs-api
@jhpratt jhpratt mentioned this pull request Jul 6, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jul 6, 2026
@bors
Auto merge of #158837 - jhpratt:rollup-KBtLguc, r=jhpratt
67e9636 
Rollup of 20 pull requests

Successful merges:

 - #158377 (add `-Zforce-intrinsic-fallback` flag)
 - #158642 (Clarify some interning details)
 - #158743 (Look for cdb location in the registry first)
 - #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
 - #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
 - #158785 (hook intrinsic-test into aarch64-gnu)
 - #157734 (Stabilize `local_key_cell_update`)
 - #158183 (std: allocate less memory in `current_exe` for OpenBSD)
 - #158671 (Move tests batch 17)
 - #158730 (Update `FIXME(static_mut_refs)` comments)
 - #158752 (Reorganize `tests/ui/issues` [18/N])
 - #158755 (Use `ThinVec` more in the AST)
 - #158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
 - #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
 - #158771 (library: expand HashSet::extract_if coverage)
 - #158772 (rustc-dev-guide subtree update)
 - #158776 (fix: emit diagnostic for AVR target without target-cpu)
 - #158786 (Add regression test for builtin attr macro values)
 - #158807 (Add regression test for CString::clone_into unwind safety)
 - #158825 (Fix typo)
@jhpratt jhpratt mentioned this pull request Jul 6, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jul 6, 2026
@bors
Auto merge of #158847 - jhpratt:rollup-MkjhKjV, r=jhpratt
29d802f 
Rollup of 24 pull requests

Successful merges:

 - #158377 (add `-Zforce-intrinsic-fallback` flag)
 - #158642 (Clarify some interning details)
 - #158694 (Positive test for closures needing expectations)
 - #158743 (Look for cdb location in the registry first)
 - #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
 - #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
 - #158785 (hook intrinsic-test into aarch64-gnu)
 - #158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
 - #157734 (Stabilize `local_key_cell_update`)
 - #158183 (std: allocate less memory in `current_exe` for OpenBSD)
 - #158310 (Remove unexpected usage of Unambig in non-infer variants)
 - #158671 (Move tests batch 17)
 - #158730 (Update `FIXME(static_mut_refs)` comments)
 - #158752 (Reorganize `tests/ui/issues` [18/N])
 - #158755 (Use `ThinVec` more in the AST)
 - #158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
 - #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
 - #158771 (library: expand HashSet::extract_if coverage)
 - #158772 (rustc-dev-guide subtree update)
 - #158776 (fix: emit diagnostic for AVR target without target-cpu)
 - #158786 (Add regression test for builtin attr macro values)
 - #158810 (Add supplementary information for get_unchecked(mut))
 - #158825 (Fix typo)
 - #158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)
rust-bors Bot pushed a commit that referenced this pull request Jul 6, 2026
@bors
Auto merge of #158847 - jhpratt:rollup-MkjhKjV, r=jhpratt
315eb8b 
Rollup of 24 pull requests

Successful merges:

 - #158377 (add `-Zforce-intrinsic-fallback` flag)
 - #158642 (Clarify some interning details)
 - #158694 (Positive test for closures needing expectations)
 - #158743 (Look for cdb location in the registry first)
 - #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
 - #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
 - #158785 (hook intrinsic-test into aarch64-gnu)
 - #158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
 - #157734 (Stabilize `local_key_cell_update`)
 - #158183 (std: allocate less memory in `current_exe` for OpenBSD)
 - #158310 (Remove unexpected usage of Unambig in non-infer variants)
 - #158671 (Move tests batch 17)
 - #158730 (Update `FIXME(static_mut_refs)` comments)
 - #158752 (Reorganize `tests/ui/issues` [18/N])
 - #158755 (Use `ThinVec` more in the AST)
 - #158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
 - #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
 - #158771 (library: expand HashSet::extract_if coverage)
 - #158772 (rustc-dev-guide subtree update)
 - #158776 (fix: emit diagnostic for AVR target without target-cpu)
 - #158786 (Add regression test for builtin attr macro values)
 - #158810 (Add supplementary information for get_unchecked(mut))
 - #158825 (Fix typo)
 - #158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)
rust-bors Bot pushed a commit that referenced this pull request Jul 6, 2026
@bors
Auto merge of #158847 - jhpratt:rollup-MkjhKjV, r=jhpratt
c4af710 
Rollup of 24 pull requests

Successful merges:

 - #158377 (add `-Zforce-intrinsic-fallback` flag)
 - #158642 (Clarify some interning details)
 - #158694 (Positive test for closures needing expectations)
 - #158743 (Look for cdb location in the registry first)
 - #158775 (bootstrap: only encode RUSTFLAGS when a flag contains a space)
 - #158782 (Add and use cfg(target_has_threads) to enforce no_thread impl usage)
 - #158785 (hook intrinsic-test into aarch64-gnu)
 - #158819 (Put `InhabitedPredicate::NotInModule` earlier in disjunction since it can be a lot faster)
 - #157734 (Stabilize `local_key_cell_update`)
 - #158183 (std: allocate less memory in `current_exe` for OpenBSD)
 - #158310 (Remove unexpected usage of Unambig in non-infer variants)
 - #158671 (Move tests batch 17)
 - #158730 (Update `FIXME(static_mut_refs)` comments)
 - #158752 (Reorganize `tests/ui/issues` [18/N])
 - #158755 (Use `ThinVec` more in the AST)
 - #158757 (Fix incorrect tracking issue for `read_le`/`read_be`)
 - #158765 (Fix ICE on non-ident path in `doc(auto_cfg values)`)
 - #158771 (library: expand HashSet::extract_if coverage)
 - #158772 (rustc-dev-guide subtree update)
 - #158776 (fix: emit diagnostic for AVR target without target-cpu)
 - #158786 (Add regression test for builtin attr macro values)
 - #158810 (Add supplementary information for get_unchecked(mut))
 - #158825 (Fix typo)
 - #158838 (tidy: Use `empty_alternate = true` for triagebot mention glob check)
@rust-bors rust-bors Bot merged commit 3568933 into rust-lang:main Jul 6, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 6, 2026
rust-timer added a commit that referenced this pull request Jul 6, 2026
@rust-timer
Unrolled build for #158757
1976c76 
Rollup merge of #158757 - kpeis695:fix/read-le-be-tracking-issue-link, r=JohnTitor

Fix incorrect tracking issue for `read_le`/`read_be`

The `#[unstable]` attribute on `Read::read_le` and `Read::read_be` pointed to #156983, which is the implementation PR. The tracking issue is #156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion.

Closes #158721

@rustbot label +A-docs +T-libs-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels

A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

read_le_be has wrong link to tracking issue

3 participants

@kpeis695 @rustbot @JohnTitor