Bump version to 1.99.0#158740
Conversation
|
@bors r+ rollup=never p=20 This needs to land ideally by ~Monday and with long CI queues, bumping the priority to help ensure that. |
This comment has been minimized.
This comment has been minimized.
|
@bors r- |
|
This pull request was unapproved. |
2ce45ea to
d97b487
Compare
|
@bors r+ rollup=never p=20 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for a2b8290 failed: CI. Failed job:
|
|
@bors retry |
|
@JonathanBrouwer @Mark-Simulacrum The relevant test seems to be hard-coding version 1.99.0 as a "version far in the future". So, this isn't a spurious failure. |
|
Oh you're right, sorry. Should've read the diff better |
cargo-side patch: rust-lang/cargo#17179 I think that means for this to be possible to bump, might need a cargo submodule bump that includes that patch...? |
…note_over_too_new_note` test (rust-lang#17179) ### What does this PR try to resolve? Unblock (IINM after a submodule update that includes this patch) version bump to 1.99.0 by using a larger placeholder future rust version in `report_rust_version_note_over_too_new_note` test. See rust-lang/rust#158740 (comment). * In the compiler, the {major, minor, patch} numbers are currently represented via `u16` in *several* places, so I elected to use `u16::MAX` here. We should be good for *a while*. ### How to test and review this PR? Exercise normally through CI.
|
rust-lang/cargo#17179 is merged. Feel free to bump the submodule in this PR. It should not have anything too unpleasant |
Also blesses tests for new deprecations.
d97b487 to
f64b38d
Compare
|
Some changes occurred in src/tools/cargo cc @ehuss |
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
This is primarily needed for the last merged PR, which fixes Cargo's tests after rustc version is bumped to 1.99.
f64b38d to
b69fc6a
Compare
|
This comment has been minimized.
This comment has been minimized.
Bump version to 1.99.0 try-job: x86_64-gnu-aux
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7148b31 (parent) -> 1c02d90 (this PR) Test differencesShow 3 test diffsStage 2
Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1c02d9026c9da54ef3323436f0ed0f8dd091d128 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (1c02d90): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -3.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 13.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 489.438s -> 490.801s (0.28%) |
View all comments
https://forge.rust-lang.org/release/process.html#bump-the-stable-version-number-friday-the-week-before
Also includes:
r? me