Skip to content

Move std::io::Write to core::io#158541

Open
bushrat011899 wants to merge 8 commits into
rust-lang:mainfrom
bushrat011899:core_io_write
Open

Move std::io::Write to core::io#158541
bushrat011899 wants to merge 8 commits into
rust-lang:mainfrom
bushrat011899:core_io_write

Conversation

@bushrat011899

@bushrat011899 bushrat011899 commented Jun 29, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

ACP: rust-lang/libs-team#755
Tracking issue: #154046
Split From: #156527
Blocked On: #158537
Blocked On: #158540

Description

Moves std::io::Write to core::io. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved into alloc and core. Blocked on #158537 and #158540.

Notes

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 29, 2026
@rustbot

rustbot commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

r? @Darksonn

rustbot has assigned @Darksonn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from 6 candidates

@bushrat011899

bushrat011899 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2026
@bushrat011899 bushrat011899 mentioned this pull request Jun 29, 2026
Open
4 tasks
@bushrat011899 bushrat011899 mentioned this pull request Jun 29, 2026
Open
@clarfonthey clarfonthey mentioned this pull request Jul 2, 2026
Merged
@bushrat011899 bushrat011899 force-pushed the core_io_write branch 2 times, most recently from ec21a69 to c806329 Compare July 3, 2026 01:49
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bushrat011899

bushrat011899 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready
@clarfonthey This is the next PR in my chain if you're interested in reviewing this one too! I'm not assigning you just in case you don't want to take it on.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 6, 2026
@clarfonthey

clarfonthey commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

r? clarfonthey

clarfonthey
clarfonthey reviewed Jul 7, 2026
View reviewed changes
Comment thread library/core/src/io/write.rs
clarfonthey
clarfonthey reviewed Jul 7, 2026
View reviewed changes
Comment thread library/core/src/io/cursor.rs Outdated
@bushrat011899 bushrat011899 requested a review from clarfonthey July 7, 2026 01:25
clarfonthey
clarfonthey reviewed Jul 7, 2026
View reviewed changes
Comment thread library/alloc/src/io/impls.rs Outdated
clarfonthey
clarfonthey reviewed Jul 7, 2026
View reviewed changes
Comment thread library/core/src/io/write.rs Outdated
@clarfonthey

clarfonthey commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Few remaining comments, otherwise looks good.

@rustbot review I did this wrong, just ignore me, we don't need to track this anyway.

bushrat011899 and others added 2 commits July 7, 2026 12:12
@bushrat011899 @clarfonthey
Reduce visibility of core::io::write::default_write_fmt
63d6ab3 
Co-Authored-By: Clar Fon <[email protected]>
@bushrat011899
Add Vec::try_extend_from_slice_of_bytes
65f6190 
Moves unsafe code from `alloc::io` into `alloc::vec`. A more general `try_extend_from_slice` may be useful in the future, but that requires changing how specialization is done for `SpecExtend` and that's a lot for an internal-only function.
@clarfonthey

clarfonthey commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup=iffy

Relatively large core::io change, will likely conflict with other changes that affect the same module.

@rust-bors

rust-bors Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 65f6190 has been approved by clarfonthey

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 8, 2026
@jhpratt
Rollup merge of rust-lang#158541 - bushrat011899:core_io_write, r=cla…
3bf8728 
…rfonthey

Move `std::io::Write` to `core::io`

ACP: rust-lang/libs-team#755
Tracking issue: rust-lang#154046
Split From: rust-lang#156527
~~Blocked On: rust-lang#158537
~~Blocked On: rust-lang#158540

## Description

Moves `std::io::Write` to `core::io`. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved into `alloc` and `core`. Blocked on rust-lang#158537 and rust-lang#158540.

---

## Notes

* No AI tooling of any kind was used during the creation of this PR.
* Please see rust-lang#154046 (comment) for a review order and broader context for this PR.
@jhpratt jhpratt mentioned this pull request Jul 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clarfonthey clarfonthey clarfonthey left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@clarfonthey clarfonthey

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bushrat011899 @rustbot @clarfonthey @Darksonn