Remove redundant dyn-compatibility check.#158477
Merged
Merged
Conversation
This check is already handled in `rustc_trait_selection::traits::fulfill::FulfillProcessor::process_obligation`.
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7fb284d (parent) -> 63f05e3 (this PR) Test differencesShow 11 test diffs11 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 63f05e3635171e7ac3f9ca78bad6c71052cda5a3 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (63f05e3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 486.093s -> 486.982s (0.18%) |
mergify Bot
pushed a commit
to ZcashFoundation/zebra
that referenced
this pull request
Jul 1, 2026
…10869) Nightly rustc from 2026-06-30 ICEs while type-checking the two return-position `impl Service<..>` test helpers, breaking the required Lint check's nightly `unused-deps` job. Return the concrete `Buffer<BoxService<..>>` and `ReadStateService` types these helpers already build, removing the opaque-type obligation that rust-lang/rust#158477 mishandles.
daira
pushed a commit
to daira/zebra
that referenced
this pull request
Jul 1, 2026
…cashFoundation#10869) Nightly rustc from 2026-06-30 ICEs while type-checking the two return-position `impl Service<..>` test helpers, breaking the required Lint check's nightly `unused-deps` job. Return the concrete `Buffer<BoxService<..>>` and `ReadStateService` types these helpers already build, removing the opaque-type obligation that rust-lang/rust#158477 mishandles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check is already handled in
rustc_trait_selection::traits::fulfill::FulfillProcessor::process_obligation.r? types