Fix typetree generation for differentiated functions by ZuseZ4 · Pull Request #158333 · rust-lang/rust

ZuseZ4 · 2026-06-23T23:30:13Z

Further improvements after #158278
This fixes a test failure on main (encountered while working on the PR above) in tests/codegen-llvm/autodiff/autodiffv2.rs.

Further improvements are split out into #158440, with high-level docs available in rust-lang/rustc-dev-guide#2911
Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, #158460

rustbot · 2026-06-23T23:30:18Z

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler, types
compiler, types expanded to 73 candidates
Random selection from 20 candidates

ZuseZ4 · 2026-06-23T23:30:24Z

r? oli-obk

ZuseZ4 · 2026-06-25T00:15:12Z

Doesn't look like Github CI will merge the previous PR anytime soon, so I'll add a few more features here in the meantime.

oli-obk · 2026-07-06T15:37:16Z

+        bug!("incorrect autodiff typetree handling for slice: {}", ty);
    }

    if ty.is_ref() || ty.is_raw_ptr() || ty.is_box() {


I think you should really turn all those if ty.thing()s into one big match on the ty.kind().

View changes since the review

…r generation for memcpy. This moves a TA failure in the testcase from memcpy to a later location.

rustbot · 2026-07-06T22:36:35Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

oli-obk

@bors r+ rollup

View changes since this review

rust-bors · 2026-07-07T05:45:45Z

📌 Commit 6bb1c07 has been approved by oli-obk

It is now in the queue for this repository.

…i-obk Fix typetree generation for differentiated functions Further improvements after rust-lang#158278 This fixes a test failure on main (encountered while working on the PR above) in `tests/codegen-llvm/autodiff/autodiffv2.rs`. Further improvements are split out into rust-lang#158440, with high-level docs available in rust-lang/rustc-dev-guide#2911 Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, rust-lang#158460

Rollup of 8 pull requests Successful merges: - #156968 (diagnostics: suggest generic_const_args for const ops) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158690 (delegation: support mapping of all arguments with `Self` type) - #158696 (Rename some `body_id` to `body_def_id`) - #158333 (Fix typetree generation for differentiated functions) - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc) - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts) - #158905 (delegation: add constraints to new generic args)

…i-obk Fix typetree generation for differentiated functions Further improvements after rust-lang#158278 This fixes a test failure on main (encountered while working on the PR above) in `tests/codegen-llvm/autodiff/autodiffv2.rs`. Further improvements are split out into rust-lang#158440, with high-level docs available in rust-lang/rustc-dev-guide#2911 Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, rust-lang#158460

…uwer Rollup of 11 pull requests Successful merges: - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158621 (disallow `extern "custom"` on wasm and spirv targets) - #158690 (delegation: support mapping of all arguments with `Self` type) - #158696 (Rename some `body_id` to `body_def_id`) - #158333 (Fix typetree generation for differentiated functions) - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc) - #158791 (Avoid unused braces lint for macro generated arguments) - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts) - #158889 (tests: catch up with LLVM returning f128 on the stack) - #158905 (delegation: add constraints to new generic args)

…i-obk Fix typetree generation for differentiated functions Further improvements after rust-lang#158278 This fixes a test failure on main (encountered while working on the PR above) in `tests/codegen-llvm/autodiff/autodiffv2.rs`. Further improvements are split out into rust-lang#158440, with high-level docs available in rust-lang/rustc-dev-guide#2911 Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, rust-lang#158460

…uwer Rollup of 18 pull requests Successful merges: - #157385 (Enable Enzyme on x86_64-apple) - #157561 (rustdoc: do not include extra stuff in span) - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158621 (disallow `extern "custom"` on wasm and spirv targets) - #158690 (delegation: support mapping of all arguments with `Self` type) - #158696 (Rename some `body_id` to `body_def_id`) - #158697 (Fixes for QNX SDP 8) - #158760 (Clarify that `LocalKey::try_with` may return `AccessError`) - #157801 (Rewrite safety requirements for `Allocator` impls) - #158333 (Fix typetree generation for differentiated functions) - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc) - #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch) - #158791 (Avoid unused braces lint for macro generated arguments) - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts) - #158841 (Avoid final override ICE for RPITIT associated types) - #158889 (tests: catch up with LLVM returning f128 on the stack) - #158905 (delegation: add constraints to new generic args)

…uwer Rollup of 19 pull requests Successful merges: - #156016 (view-types: store view types in the AST) - #157385 (Enable Enzyme on x86_64-apple) - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS) - #158621 (disallow `extern "custom"` on wasm and spirv targets) - #158690 (delegation: support mapping of all arguments with `Self` type) - #158696 (Rename some `body_id` to `body_def_id`) - #158697 (Fixes for QNX SDP 8) - #158760 (Clarify that `LocalKey::try_with` may return `AccessError`) - #157801 (Rewrite safety requirements for `Allocator` impls) - #158085 (rustdoc: Fix sidebar heading order) - #158333 (Fix typetree generation for differentiated functions) - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc) - #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch) - #158791 (Avoid unused braces lint for macro generated arguments) - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts) - #158841 (Avoid final override ICE for RPITIT associated types) - #158889 (tests: catch up with LLVM returning f128 on the stack) - #158905 (delegation: add constraints to new generic args) - #158922 (tests: clean up over-constraint on LLVM feature count) Failed merges: - #158617 (allow mGCA const arguments to fall back to anon consts)

Rollup merge of #158333 - ZuseZ4:typetrees-for-enzyme3, r=oli-obk Fix typetree generation for differentiated functions Further improvements after #158278 This fixes a test failure on main (encountered while working on the PR above) in `tests/codegen-llvm/autodiff/autodiffv2.rs`. Further improvements are split out into #158440, with high-level docs available in rust-lang/rustc-dev-guide#2911 Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, #158460

rustbot assigned mu001999 Jun 23, 2026

rustbot assigned oli-obk and unassigned mu001999 Jun 23, 2026

This comment has been minimized.

Sign in to view

ZuseZ4 marked this pull request as draft June 25, 2026 00:15

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2026

This comment has been minimized.

Sign in to view

ZuseZ4 force-pushed the typetrees-for-enzyme3 branch 2 times, most recently from 3227538 to 64d9d50 Compare June 26, 2026 10:59

ZuseZ4 mentioned this pull request Jun 26, 2026

autodiff: generate TypeTree metadata for extractvalue #158440

Draft

This comment has been minimized.

Sign in to view

ZuseZ4 mentioned this pull request Jun 27, 2026

Remove llvm_enzyme feature outside of bootstrap #158460

Draft

ZuseZ4 force-pushed the typetrees-for-enzyme3 branch from 64d9d50 to 75c0091 Compare June 30, 2026 02:32

rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jun 30, 2026

ZuseZ4 marked this pull request as ready for review June 30, 2026 02:36

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2026

oli-obk reviewed Jul 6, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/builder/autodiff.rs Outdated

oli-obk reviewed Jul 6, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/builder/autodiff.rs Outdated

oli-obk reviewed Jul 6, 2026

View reviewed changes

oli-obk requested changes Jul 6, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2026

ZuseZ4 force-pushed the typetrees-for-enzyme3 branch from 75c0091 to b079a9d Compare July 6, 2026 18:34

ZuseZ4 added 2 commits July 6, 2026 23:10

Fix typetree generation for arguments, like slices and re-enable thei…

de73ac0

…r generation for memcpy. This moves a TA failure in the testcase from memcpy to a later location.

Refactor the Type to TypeTree parser into a large match

6bb1c07

ZuseZ4 force-pushed the typetrees-for-enzyme3 branch from b079a9d to 6bb1c07 Compare July 6, 2026 22:36

ZuseZ4 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 6, 2026

oli-obk approved these changes Jul 7, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2026

m-ou-se mentioned this pull request Jul 7, 2026

Rollup of 8 pull requests #158906

Closed

JonathanBrouwer mentioned this pull request Jul 7, 2026

Rollup of 9 pull requests #158909

Closed

JonathanBrouwer mentioned this pull request Jul 7, 2026

Rollup of 11 pull requests #158911

Closed

JonathanBrouwer mentioned this pull request Jul 7, 2026

Rollup of 18 pull requests #158923

Closed

JonathanBrouwer mentioned this pull request Jul 7, 2026

Rollup of 19 pull requests #158924

Merged

rust-bors Bot merged commit 820771b into rust-lang:main Jul 8, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Jul 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix typetree generation for differentiated functions#158333

Fix typetree generation for differentiated functions#158333
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
ZuseZ4:typetrees-for-enzyme3

ZuseZ4 commented Jun 23, 2026 •

edited

Loading

Uh oh!

rustbot commented Jun 23, 2026

Uh oh!

ZuseZ4 commented Jun 23, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

ZuseZ4 commented Jun 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

oli-obk Jul 6, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

oli-obk left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

ZuseZ4 commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 23, 2026

Uh oh!

ZuseZ4 commented Jun 23, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

ZuseZ4 commented Jun 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

oli-obk Jul 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

oli-obk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ZuseZ4 commented Jun 23, 2026 •

edited

Loading

oli-obk Jul 6, 2026 •

edited by rustbot

Loading

oli-obk left a comment •

edited by rustbot

Loading