Update the rustc_perf submodule by jdonszelmann · Pull Request #158245 · rust-lang/rust

jdonszelmann · 2026-06-22T11:54:36Z

I hope this is a thing that's ok to do, I never update submodules but this one seems to be 8 months old and we got some new benchmarks in the meantime.

r? @Kobzol

rustbot · 2026-06-22T11:54:41Z

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

rustbot · 2026-06-22T11:54:47Z

⚠️ Warning ⚠️

Some commits in this PR modify submodules.

If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

rustbot · 2026-06-22T15:25:40Z

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

Mark-Simulacrum · 2026-06-22T15:33:10Z

Note that 'new benchmarks' here largely doesn't matter, we filter down what is actually executed in CI here:

rust/src/build_helper/src/lib.rs

Lines 14 to 36 in cddcbec

    
           /// The default set of crates for opt-dist to collect LLVM profiles. 
        
           pub const LLVM_PGO_CRATES: &[&str] = &[ 
        
               "syn-2.0.101", 
        
               "cargo-0.87.1", 
        
               "serde-1.0.219", 
        
               "ripgrep-14.1.1", 
        
               "regex-automata-0.4.8", 
        
               "clap_derive-4.5.32", 
        
               "hyper-1.6.0", 
        
           ]; 
        
           /// The default set of crates for opt-dist to collect rustc profiles. 
        
           pub const RUSTC_PGO_CRATES: &[&str] = &[ 
        
               "externs", 
        
               "ctfe-stress-5", 
        
               "cargo-0.87.1", 
        
               "token-stream-stress", 
        
               "match-stress", 
        
               "tuple-stress", 
        
               "diesel-2.2.10", 
        
               "bitmaps-3.2.1", 
        
               "serde-1.0.219-new-solver", 
        
           ];

But I think it's good to keep the submodule somewhat up to date regardless, to reduce drift / unrelated issues creeping in when we do need to tweak it.

jdonszelmann · 2026-06-22T15:33:47Z

well, it matters for local perf runs (x perf) which I do regularly

jdonszelmann · 2026-06-22T15:58:56Z

See #t-compiler/contrib-private > Licenses for the discussion on license changes, the upshot it: it's probably fine to do what this PR does

Mark-Simulacrum · 2026-06-25T11:54:30Z

@bors try @rust-timer queue

(Not expecting any issues but let's make sure).

Mark-Simulacrum · 2026-06-25T11:54:36Z

r? me

Update the rustc_perf submodule

rust-bors · 2026-06-25T12:10:00Z

💔 Test for 63cc3b0 failed: CI. Failed job:

try - dist-x86_64-linux-quick (web logs, enhanced plaintext logs)

jdonszelmann · 2026-06-25T12:47:58Z

CI is incredibly flaky today and the past few days.

Update the rustc_perf submodule

rust-bors · 2026-06-25T14:07:30Z

💔 Test for f1604c6 failed: CI. Failed job:

try - dist-x86_64-linux-quick (web logs, enhanced plaintext logs)

rustbot · 2026-07-06T08:14:01Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2026-07-06T11:47:29Z

@rustbot review

Kobzol · 2026-07-06T14:18:55Z

@bors try @rust-timer queue

Update the rustc_perf submodule

rust-bors · 2026-07-06T16:27:30Z

☀️ Try build successful (CI)
Build commit: 38c9cd6 (38c9cd674b8b8a34ae7e72c690b23d294d84d851)
Base parent: 3c00c96 (3c00c96d3af4d5b5e101e56cc161a608b21366ee)

rust-timer · 2026-07-06T17:12:17Z

Finished benchmarking commit (38c9cd6): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.8%, secondary -4.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.3%	[4.3%, 4.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-4.7%	[-4.7%, -4.7%]	1
All ❌✅ (primary)	1.8%	[-0.7%, 4.3%]	2

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-0.0%, -0.0%]	4

Bootstrap: 491.018s -> 490.18s (-0.17%)
Artifact size: 388.45 MiB -> 388.92 MiB (0.12%)

Kobzol · 2026-07-06T18:15:57Z

Looks good, thank you!

@bors r+ rollup

rust-bors · 2026-07-06T18:16:00Z

📌 Commit a6bd564 has been approved by Kobzol

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 6. This pull request will be tested once the tree is reopened.

@Kobzol

…Kobzol Update the rustc_perf submodule I hope this is a thing that's ok to do, I never update submodules but this one seems to be 8 months old and we got some new benchmarks in the meantime. r? @Kobzol

Rollup of 13 pull requests Successful merges: - #158478 (Use correct typing mode in mir building for the next solver) - #158796 (Distinguish null reference production from null pointer dereference in UB checks) - #158821 (add regression test for late-bound type method probe ICE) - #158245 (Update the rustc_perf submodule) - #158346 (Prevent rustdoc auto-trait ICEs with `-Znext-solver=globally`) - #158536 (Instatiate binder instead of skipping when suggesting function arg error) - #158553 (Avoid infinite recursion when trying to build valtrees for self-referential consts) - #158679 (Document blocking guarantees for `std::sync`) - #158826 (Reorganize `tests/ui/issues` [19/N]) - #158860 (Delete `impl_def_id` field from `ImplHeader`) - #158867 (rewrite `Align::max_for_target` in a more obvious way) - #158878 (borrowck: Inline `free_region_constraint_info()` to simplify the code) - #158881 (Update mdbook to 0.5.4)

@Kobzol

Rollup merge of #158245 - jdonszelmann:update-rustc-perf, r=Kobzol Update the rustc_perf submodule I hope this is a thing that's ok to do, I never update submodules but this one seems to be 8 months old and we got some new benchmarks in the meantime. r? @Kobzol

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 22, 2026

rustbot assigned Kobzol Jun 22, 2026

jdonszelmann marked this pull request as ready for review June 22, 2026 11:54

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2026

This comment has been minimized.

Sign in to view

rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 22, 2026

jdonszelmann force-pushed the update-rustc-perf branch from 4db46f7 to f79fa40 Compare June 22, 2026 15:49

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 25, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 25, 2026

Auto merge of #158245 - jdonszelmann:update-rustc-perf, r=<try>

63cc3b0

Update the rustc_perf submodule

rustbot assigned Mark-Simulacrum and unassigned Kobzol Jun 25, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2026

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the update-rustc-perf branch from f79fa40 to 7a742bc Compare June 25, 2026 13:54

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 25, 2026

Auto merge of #158245 - jdonszelmann:update-rustc-perf, r=<try>

f1604c6

Update the rustc_perf submodule

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the update-rustc-perf branch from 7a742bc to 2bd04b2 Compare July 6, 2026 08:13

jdonszelmann added 2 commits July 6, 2026 11:23

update perf

a99be5a

allow new licenses for rustc_perf

a6bd564

jdonszelmann force-pushed the update-rustc-perf branch from 2bd04b2 to a6bd564 Compare July 6, 2026 09:28

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 6, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 6, 2026

Auto merge of #158245 - jdonszelmann:update-rustc-perf, r=<try>

38c9cd6

Update the rustc_perf submodule

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 6, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2026

JonathanBrouwer mentioned this pull request Jul 6, 2026

Rollup of 7 pull requests #158884

Closed

jhpratt mentioned this pull request Jul 7, 2026

Rollup of 13 pull requests #158891

Merged

rust-bors Bot merged commit 96b5fba into rust-lang:main Jul 7, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 7, 2026

Uh oh!

Uh oh!

Conversation

jdonszelmann commented Jun 22, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 22, 2026

Uh oh!

rustbot commented Jun 22, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jun 22, 2026

Uh oh!

Mark-Simulacrum commented Jun 22, 2026

Uh oh!

jdonszelmann commented Jun 22, 2026

Uh oh!

jdonszelmann commented Jun 22, 2026

Uh oh!

Mark-Simulacrum commented Jun 25, 2026

Uh oh!

This comment has been minimized.

Mark-Simulacrum commented Jun 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 25, 2026

Uh oh!

This comment has been minimized.

jdonszelmann commented Jun 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 25, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jul 6, 2026

Uh oh!

jdonszelmann commented Jul 6, 2026

Uh oh!

Kobzol commented Jul 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jul 6, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 6, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Kobzol commented Jul 6, 2026

Uh oh!

rust-bors Bot commented Jul 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jdonszelmann commented Jun 22, 2026 •

edited by rustbot

Loading