Skip to content

Implement new mod import sugar #15808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from Jul 20, 2014
Merged

Implement new mod import sugar #15808

bors merged 1 commit into from Jul 20, 2014

Conversation

@ghost
Copy link

@ghost ghost commented Jul 19, 2014

Implements RFC #168.

@huonw
Copy link
Contributor

huonw commented Jul 19, 2014

Cool!

Tests I would like to see:

  • use foo::mod; without the {} (should have a nice, custom error message, if it's an error)
  • checking that pub use correctly reexports the module.
  • foo::{mod} (i.e. nothing else in the import list)
  • what do use self::{mod} and use super::{mod} do? (at the very least, they shouldn't ICE...)

@ghost
Copy link
Author

ghost commented Jul 19, 2014

@huonw I added more tests and a nicer diagnostic for foo::mod.

alexcrichton
alexcrichton reviewed Jul 20, 2014
View reviewed changes
src/librustc/middle/privacy.rs Outdated
Copy link
Member

@alexcrichton alexcrichton Jul 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make sure that something like this still doesn't work?

use foo::bar::{mod, Bar};

mod foo {
    mod bar { pub type Bar = int; }
}

fn main() {}

Copy link
Author

@ghost ghost Jul 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a great call.

use foo::bar::{mod};

should definitely fail to compile if bar is private. I added a test.

@alexcrichton
Copy link
Member

alexcrichton commented Jul 20, 2014

Awesome work @jakub-!

@ghost
Copy link
Author

ghost commented Jul 20, 2014

@alexcrichton Thanks for the review. I addressed your comments.

bors added a commit that referenced this pull request Jul 20, 2014
@bors
auto merge of #15808 : jakub-/rust/use-mod, r=alexcrichton
8748a69 
Implements RFC #168.
@bors bors closed this Jul 20, 2014
@bors bors merged commit 4b9bc2e into rust-lang:master Jul 20, 2014
@alexcrichton alexcrichton mentioned this pull request Jul 23, 2014
Closed
@ghost ghost deleted the use-mod branch August 18, 2014 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huonw @alexcrichton @bors