windows/time: avoid being too close to 0#156177
Open
RalfJung wants to merge 1 commit intorust-lang:mainfrom
Open
windows/time: avoid being too close to 0#156177RalfJung wants to merge 1 commit intorust-lang:mainfrom
RalfJung wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
RalfJung
force-pushed
the
windows-time-epoch
branch
from
99d0aef to
a07a3b1
Compare
tbu-
reviewed
May 6, 2026
| // We can add an arbitrary offset to shift the epoch of this clock. We do that to avoid | ||
| // being too close to 0 which would lead to underflow when computing times in the past. Also | ||
| // see <https://github.com/rust-lang/rust/issues/156142>. | ||
| let instant_nsec = instant_nsec + (u64::MAX / 4); |
Contributor
There was a problem hiding this comment.
Would be nicer to use a signed type for storing the nanoseconds, otherwise we have this useless addition on every Instant::now.
Using a signed type would make this essentially free.
Member
Author
There was a problem hiding this comment.
We use Duration so using anything singed would be a major refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156142 (but only for Windows -- should we still track it for non-tier-1-platforms?)