Implement a new flag -Zdisable-fast-paths in trait solving#156172
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom May 5, 2026
Merged
Implement a new flag -Zdisable-fast-paths in trait solving#156172rust-bors[bot] merged 1 commit intorust-lang:mainfrom
-Zdisable-fast-paths in trait solving#156172rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rustbot
added
S-waiting-on-review
lcnr
reviewed
May 5, 2026
| themselves (default: no)"), | ||
| direct_access_external_data: Option<bool> = (None, parse_opt_bool, [TRACKED], | ||
| "Direct or use GOT indirect to reference external data symbols"), | ||
| disable_fast_paths: bool = (false, parse_bool, [UNTRACKED], |
Contributor
There was a problem hiding this comment.
i think this in theory impacts behavior, so it should be TRACKED 🤔
Member
Author
There was a problem hiding this comment.
Ah, right. I actually got some codes failing to compile with the flags due to the overflow since we don't do compute_goal_fast_path with it but goes into the nested goals
Member
Author
|
@bors r=lcnr |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
May 5, 2026
…uwer Rollup of 7 pull requests Successful merges: - #156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better) - #156058 (Print HRTB binders before fn qualifiers) - #156172 (Implement a new flag `-Zdisable-fast-paths` in trait solving) - #156184 (Revert "remove `MethodReceiverExpr` special-casing") - #155957 (Revert const hacks and use const closures in std) - #156127 (Update `askama` version to `0.16.0`) - #156183 (Remove duplicate debug assert)
rust-bors Bot
pushed a commit
that referenced
this pull request
May 5, 2026
…uwer Rollup of 7 pull requests Successful merges: - #156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better) - #156058 (Print HRTB binders before fn qualifiers) - #156172 (Implement a new flag `-Zdisable-fast-paths` in trait solving) - #156184 (Revert "remove `MethodReceiverExpr` special-casing") - #155957 (Revert const hacks and use const closures in std) - #156127 (Update `askama` version to `0.16.0`) - #156183 (Remove duplicate debug assert)
rust-bors Bot
pushed a commit
that referenced
this pull request
May 5, 2026
…uwer Rollup of 7 pull requests Successful merges: - #156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better) - #156058 (Print HRTB binders before fn qualifiers) - #156172 (Implement a new flag `-Zdisable-fast-paths` in trait solving) - #156184 (Revert "remove `MethodReceiverExpr` special-casing") - #155957 (Revert const hacks and use const closures in std) - #156127 (Update `askama` version to `0.16.0`) - #156183 (Remove duplicate debug assert)
rust-timer
added a commit
that referenced
this pull request
May 5, 2026
Rollup merge of #156172 - ShoyuVanilla:slowbro, r=lcnr Implement a new flag `-Zdisable-fast-paths` in trait solving Discussion: [#t-types/trait-system-refactor > ask for help @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/ask.20for.20help/near/583953725) r? lcnr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion: #t-types/trait-system-refactor > ask for help @ 💬
r? lcnr