Fix a coroutine UI test which is missing #[coroutine]#156171
Open
teor2345 wants to merge 2 commits intorust-lang:mainfrom
Open
Fix a coroutine UI test which is missing #[coroutine]#156171teor2345 wants to merge 2 commits intorust-lang:mainfrom
#[coroutine]#156171teor2345 wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in coverage tests. cc @Zalathar |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @BoxyUwU rustbot has assigned @BoxyUwU. Use Why was this reviewer chosen?The reviewer was selected based on:
|
teor2345
commented
May 5, 2026
Comment on lines
47
to
50
| @@ -50,8 +50,9 @@ fn closure_sig() -> impl Sized { | |||
| } | |||
Contributor
Author
There was a problem hiding this comment.
The code was the same as this test, which doesn't make sense, and makes it look like a copy-paste typo.
Edit: sigh, I selected all the test code, but it looks like GitHub decided to hide the lines outside the diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks like a typo, although the test now produces a different error to the other errors in the file.
I also fixed some comment typos in tests, happy to drop that commit if you don't want to review it.