Further optimize SliceIndex<str> impl for Range<usize>#156119
Open
Kmeakin wants to merge 1 commit intorust-lang:mainfrom
Open
Further optimize SliceIndex<str> impl for Range<usize>#156119Kmeakin wants to merge 1 commit intorust-lang:mainfrom
SliceIndex<str> impl for Range<usize>#156119Kmeakin wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @scottmcm rustbot has assigned @scottmcm. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Kmeakin
force-pushed
the
km/optimize-str-index
branch
from
492232c to
3693b41
Compare
This comment has been minimized.
This comment has been minimized.
Kmeakin
force-pushed
the
km/optimize-str-index
branch
from
3693b41 to
04d9b91
Compare
This comment has been minimized.
This comment has been minimized.
We can shave a further 2 `icmp`s by inlining `is_char_boundary` and rearranging the checks.
Kmeakin
force-pushed
the
km/optimize-str-index
branch
from
04d9b91 to
ef9eff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can shave a further 2
icmps by inliningis_char_boundaryand rearranging the checks.Follow up to #145024