Remove unused spans from AttributeKind#156065
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom May 3, 2026
Merged
Conversation
Collaborator
|
Some changes occurred in match checking cc @Nadrieril Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in coverage instrumentation. cc @Zalathar Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer The Clippy subtree was changed cc @rust-lang/clippy Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Collaborator
|
r? @oli-obk rustbot has assigned @oli-obk. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
rust-bors Bot
pushed a commit
that referenced
this pull request
May 1, 2026
Remove unused spans from AttributeKind
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (54e80b0): comparison URL. Overall result: no relevant changes - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 3.6%, secondary 1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 5.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 487.864s -> 482.272s (-1.15%) |
rustbot
removed
the
S-waiting-on-perf
JonathanBrouwer
approved these changes
May 2, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This was referenced May 2, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
May 2, 2026
…uwer Rollup of 9 pull requests Successful merges: - #156030 (Make stable hashing names consistent (part 1)) - #156020 (Improve source code for `librustdoc/visit_ast.rs`) - #156021 (Clean up some traits) - #156028 (Add a `Local::arg(i)` helper constructor) - #156037 (Add AcceptContext::expect_no_args) - #156040 (Add missing alias to mailmap) - #156048 (Make `diverging_type_vars` a vec of `TyVid`) - #156053 (Reuse CTFE MIR for constructors.) - #156059 (compiler: Print valid `-Zmir-enable-passes` names if invalid name is used) Failed merges: - #155940 (refactor rustc_on_unimplemented's filtering) - #156065 (Remove unused spans from AttributeKind)
rust-bors
Bot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 2, 2026
Remove unused spans from AttributeKind Recently I noticed some spans in diagnostic attributes were never used. I went through and checked the other variants too.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 2, 2026
Remove unused spans from AttributeKind Recently I noticed some spans in diagnostic attributes were never used. I went through and checked the other variants too.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 3, 2026
…uwer Rollup of 5 pull requests Successful merges: - #152277 (Validate source snippet when format input is raw string) - #155940 (refactor rustc_on_unimplemented's filtering) - #156065 (Remove unused spans from AttributeKind) - #156079 (Move and rename the `clone-never.rs` test) - #156091 (change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools`)
rust-bors Bot
pushed a commit
that referenced
this pull request
May 3, 2026
Rollup of 5 pull requests Successful merges: - #155666 (Interning cleanups) - #155940 (refactor rustc_on_unimplemented's filtering) - #156065 (Remove unused spans from AttributeKind) - #156079 (Move and rename the `clone-never.rs` test) - #156091 (change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools`)
rust-timer
added a commit
that referenced
this pull request
May 3, 2026
Rollup merge of #156065 - mejrs:spanculler, r=JonathanBrouwer Remove unused spans from AttributeKind Recently I noticed some spans in diagnostic attributes were never used. I went through and checked the other variants too.
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
May 4, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#156030 (Make stable hashing names consistent (part 1)) - rust-lang/rust#156020 (Improve source code for `librustdoc/visit_ast.rs`) - rust-lang/rust#156021 (Clean up some traits) - rust-lang/rust#156028 (Add a `Local::arg(i)` helper constructor) - rust-lang/rust#156037 (Add AcceptContext::expect_no_args) - rust-lang/rust#156040 (Add missing alias to mailmap) - rust-lang/rust#156048 (Make `diverging_type_vars` a vec of `TyVid`) - rust-lang/rust#156053 (Reuse CTFE MIR for constructors.) - rust-lang/rust#156059 (compiler: Print valid `-Zmir-enable-passes` names if invalid name is used) Failed merges: - rust-lang/rust#155940 (refactor rustc_on_unimplemented's filtering) - rust-lang/rust#156065 (Remove unused spans from AttributeKind)
pull Bot
pushed a commit
to Kokoro2336/rust-analyzer
that referenced
this pull request
May 4, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#156030 (Make stable hashing names consistent (part 1)) - rust-lang/rust#156020 (Improve source code for `librustdoc/visit_ast.rs`) - rust-lang/rust#156021 (Clean up some traits) - rust-lang/rust#156028 (Add a `Local::arg(i)` helper constructor) - rust-lang/rust#156037 (Add AcceptContext::expect_no_args) - rust-lang/rust#156040 (Add missing alias to mailmap) - rust-lang/rust#156048 (Make `diverging_type_vars` a vec of `TyVid`) - rust-lang/rust#156053 (Reuse CTFE MIR for constructors.) - rust-lang/rust#156059 (compiler: Print valid `-Zmir-enable-passes` names if invalid name is used) Failed merges: - rust-lang/rust#155940 (refactor rustc_on_unimplemented's filtering) - rust-lang/rust#156065 (Remove unused spans from AttributeKind)
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::NoStd` is now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910142545
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::NoStd` is now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910142545
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::NoStd` is now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910142545
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::{NoStd, NoCore}` are now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910142545
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::{NoStd, NoCore}` are now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910142545
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::{NoStd, NoCore}` are now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910219736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently I noticed some spans in diagnostic attributes were never used. I went through and checked the other variants too.