Skip to content

Map WSAESHUTDOWN to io::ErrorKind::BrokenPipe#156063

Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
WhySoBad:wsaeshutdown-error-kind
May 2, 2026
Merged

Map WSAESHUTDOWN to io::ErrorKind::BrokenPipe#156063
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
WhySoBad:wsaeshutdown-error-kind

Conversation

@WhySoBad
Copy link
Copy Markdown
Contributor

@WhySoBad WhySoBad commented May 1, 2026

As discussed in #t-libs > WSAESHUTDOWN error on Windows, this adds the mapping for WSAESHUTDOWN on Windows to io::ErrorKind::BrokenPipe.

r? RalfJung

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2026
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 1, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 1, 2026

RalfJung is not on the review rotation at the moment.
They may take a while to respond.

@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented May 1, 2026

r? @ChrisDenton

@rustbot rustbot assigned ChrisDenton and unassigned RalfJung May 1, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 1, 2026

ChrisDenton is not on the review rotation at the moment.
They may take a while to respond.

Comment thread library/std/src/sys/io/error/windows.rs Outdated
@ChrisDenton
Copy link
Copy Markdown
Member

r=me once ralf's comment is addressed.

I don't know if this needs a full FCP but at the very least someone from libs-api will need to sign off on it. cc @joshtriplett

@ChrisDenton ChrisDenton added the S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api label May 1, 2026
@joshtriplett joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label May 1, 2026
Comment thread library/std/src/sys/io/error/windows.rs Outdated
@joshtriplett
Copy link
Copy Markdown
Member

I don't think this needs an FCP, but I'm nominating it for discussion.

@joshtriplett joshtriplett added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label May 1, 2026
@joshtriplett
Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 1, 2026

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-t-libs-api.

@joshtriplett joshtriplett removed the S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api label May 1, 2026
@joshtriplett
Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 1, 2026

📌 Commit e6c358b has been approved by joshtriplett

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2026
rust-bors Bot pushed a commit that referenced this pull request May 2, 2026
Rollup of 4 pull requests

Successful merges:

 - #154571 (Fix alias path for rustdoc)
 - #155749 (`-Znext-solver` Ignore region constraints from the nested goals in leakcheck)
 - #156026 (`bufreader::Buffer`: Remove leftover note about `initialized` field)
 - #156063 (Map `WSAESHUTDOWN` to `io::ErrorKind::BrokenPipe`)
@rust-bors rust-bors Bot merged commit 50805a9 into rust-lang:main May 2, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I-libs-api-nominated Nominated for discussion during a libs-api team meeting. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants