Document which open commands will follow symlinks#156034
Open
alexanderkjall wants to merge 1 commit intorust-lang:mainfrom
Open
Document which open commands will follow symlinks#156034alexanderkjall wants to merge 1 commit intorust-lang:mainfrom
alexanderkjall wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @nia-e rustbot has assigned @nia-e. Use Why was this reviewer chosen?The reviewer was selected based on:
|
nia-e
added
the
I-libs-api-nominated
Member
|
Needs team signoff for committing to this, but seems useful ^^ |
Member
|
We discussed this in the @rust-lang/libs-api meeting. This isn't an API change, it's just describing the normal behavior of symbolic link. In fact, it would be better if this was documented in the |
Amanieu
removed
the
I-libs-api-nominated
nia-e
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As symlinks are a concept that it's easy to forget to think about when writing filesystem centric code.
Inspired by this: tower-rs/tower-http#658