Make stable hashing names consistent (part 1)#156030
Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom May 2, 2026
Merged
Make stable hashing names consistent (part 1)#156030rust-bors[bot] merged 4 commits intorust-lang:mainfrom
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_ast/src/expand/autodiff_attrs.rs cc @ZuseZ4 Some changes occurred to diagnostic attributes. cc @mejrs Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in cc @BoxyUwU The Cranelift subtree was changed cc @bjorn3 rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer Some changes occurred in coverage instrumentation. cc @Zalathar
cc @TaKO8Ki The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr These commits modify compiler targets. This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @vakaras Some changes occurred in compiler/rustc_ast/src/expand/typetree.rs cc @ZuseZ4 |
rustbot
added
A-attributes
JonathanBrouwer
approved these changes
May 1, 2026
Contributor
There was a problem hiding this comment.
r=me after rust-lang/compiler-team#983 is accepted
JonathanBrouwer
added
S-blocked
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
removed
the
S-blocked
JonathanBrouwer
force-pushed
the
StableHash-renamings
branch
from
3e181f9 to
36b9dd7
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
^ Solved conflicts |
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 2, 2026
…r=JonathanBrouwer
Make stable hashing names consistent (part 1)
This PR starts the implementation of MCP 893. It renames the things that appear in the `HashStable` trait, changing this:
```
pub trait HashStable {
fn hash_stable<Hcx: HashStableContext>(&self, hcx: &mut Hcx, hasher: &mut StableHasher);
}
```
to this:
```
pub trait StableHash {
fn stable_hash<Hcx: StableHashCtxt>(&self, hcx: &mut Hcx, hasher: &mut StableHasher);
}
```
Details in individual commits.
This is the biggest part of the renaming. A follow-up PR will rename the remaining things.
r? @jieyouxu
Part of MCP 983.
Part of MCP 983.
Specifically: - `HashStable` -> `StableHash` (trait) - `HashStable` -> `StableHash` (derive) - `HashStable_NoContext` -> `StableHash_NoContext` (derive) Note: there are some names in `compiler/rustc_macros/src/hash_stable.rs` that are still to be renamed, e.g. `HashStableMode`. Part of MCP 983.
JonathanBrouwer
force-pushed
the
StableHash-renamings
branch
from
36b9dd7 to
e7d28d3
Compare
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
This pull request was unapproved. |
rust-bors
Bot
removed
the
S-waiting-on-bors
Contributor
|
^ Rebased to solve a soft conflict |
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
May 2, 2026
…uwer Rollup of 9 pull requests Successful merges: - #156030 (Make stable hashing names consistent (part 1)) - #156020 (Improve source code for `librustdoc/visit_ast.rs`) - #156021 (Clean up some traits) - #156028 (Add a `Local::arg(i)` helper constructor) - #156037 (Add AcceptContext::expect_no_args) - #156040 (Add missing alias to mailmap) - #156048 (Make `diverging_type_vars` a vec of `TyVid`) - #156053 (Reuse CTFE MIR for constructors.) - #156059 (compiler: Print valid `-Zmir-enable-passes` names if invalid name is used) Failed merges: - #155940 (refactor rustc_on_unimplemented's filtering) - #156065 (Remove unused spans from AttributeKind)
rust-timer
added a commit
that referenced
this pull request
May 2, 2026
Rollup merge of #156030 - nnethercote:StableHash-renamings, r=JonathanBrouwer Make stable hashing names consistent (part 1) This PR starts the implementation of MCP 893. It renames the things that appear in the `HashStable` trait, changing this: ``` pub trait HashStable { fn hash_stable<Hcx: HashStableContext>(&self, hcx: &mut Hcx, hasher: &mut StableHasher); } ``` to this: ``` pub trait StableHash { fn stable_hash<Hcx: StableHashCtxt>(&self, hcx: &mut Hcx, hasher: &mut StableHasher); } ``` Details in individual commits. This is the biggest part of the renaming. A follow-up PR will rename the remaining things. r? @jieyouxu
6 tasks
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
May 4, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#156030 (Make stable hashing names consistent (part 1)) - rust-lang/rust#156020 (Improve source code for `librustdoc/visit_ast.rs`) - rust-lang/rust#156021 (Clean up some traits) - rust-lang/rust#156028 (Add a `Local::arg(i)` helper constructor) - rust-lang/rust#156037 (Add AcceptContext::expect_no_args) - rust-lang/rust#156040 (Add missing alias to mailmap) - rust-lang/rust#156048 (Make `diverging_type_vars` a vec of `TyVid`) - rust-lang/rust#156053 (Reuse CTFE MIR for constructors.) - rust-lang/rust#156059 (compiler: Print valid `-Zmir-enable-passes` names if invalid name is used) Failed merges: - rust-lang/rust#155940 (refactor rustc_on_unimplemented's filtering) - rust-lang/rust#156065 (Remove unused spans from AttributeKind)
pull Bot
pushed a commit
to Kokoro2336/rust-analyzer
that referenced
this pull request
May 4, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#156030 (Make stable hashing names consistent (part 1)) - rust-lang/rust#156020 (Improve source code for `librustdoc/visit_ast.rs`) - rust-lang/rust#156021 (Clean up some traits) - rust-lang/rust#156028 (Add a `Local::arg(i)` helper constructor) - rust-lang/rust#156037 (Add AcceptContext::expect_no_args) - rust-lang/rust#156040 (Add missing alias to mailmap) - rust-lang/rust#156048 (Make `diverging_type_vars` a vec of `TyVid`) - rust-lang/rust#156053 (Reuse CTFE MIR for constructors.) - rust-lang/rust#156059 (compiler: Print valid `-Zmir-enable-passes` names if invalid name is used) Failed merges: - rust-lang/rust#155940 (refactor rustc_on_unimplemented's filtering) - rust-lang/rust#156065 (Remove unused spans from AttributeKind)
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::NoStd` is now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910142545
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::NoStd` is now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910142545
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::NoStd` is now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910142545
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::{NoStd, NoCore}` are now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910142545
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::{NoStd, NoCore}` are now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910142545
copybara-service Bot
pushed a commit
to google/crubit
that referenced
this pull request
May 4, 2026
1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match.
rust-lang/rust#156030
2. `rustc_hir::attrs::AttributeKind::{NoStd, NoCore}` are now fieldless.
rust-lang/rust#156065
PiperOrigin-RevId: 910219736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts the implementation of MCP 893. It renames the things that appear in the
HashStabletrait, changing this:to this:
Details in individual commits.
This is the biggest part of the renaming. A follow-up PR will rename the remaining things.
r? @jieyouxu