Skip to content

tests: mark simple UI tests as check-pass#155947

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
SynapLink:cleanup/check-pass-variance-tests
Apr 29, 2026
Merged

tests: mark simple UI tests as check-pass#155947
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
SynapLink:cleanup/check-pass-variance-tests

Conversation

@SynapLink
Copy link
Copy Markdown
Contributor

@SynapLink SynapLink commented Apr 28, 2026

This changes 14 simple UI tests from build-pass to check-pass.

These tests cover type checking, trait bounds, closure inference, deprecation diagnostics, dyn compatibility, and variance. They do not need codegen or linking, so check-pass keeps the intended coverage while removing old FIXME(62277) markers.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 28, 2026
@SynapLink SynapLink force-pushed the cleanup/check-pass-variance-tests branch from 4743ac2 to b19b0e5 Compare April 28, 2026 21:10
@SynapLink SynapLink changed the title tests: mark variance UI tests as check-pass tests: mark simple UI tests as check-pass Apr 28, 2026
@SynapLink SynapLink marked this pull request as ready for review April 28, 2026 21:12
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 28, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 28, 2026

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 21 candidates

@nnethercote
Copy link
Copy Markdown
Contributor

LLMs often produce verbose descriptions with lots of unnecessary detail. PR descriptions end up in the repository as merge commit messages, so this unnecessary detail pollutes history.

Please remove "Checks run:" and everything that follows from the PR description; those python commands are very basic information that don't add anything interesting.

@SynapLink
Copy link
Copy Markdown
Contributor Author

LLMs often produce verbose descriptions with lots of unnecessary detail. PR descriptions end up in the repository as merge commit messages, so this unnecessary detail pollutes history.

Please remove "Checks run:" and everything that follows from the PR description; those python commands are very basic information that don't add anything interesting.

Done, thanks. Will not add that in future prs

@nnethercote
Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

📌 Commit b19b0e5 has been approved by nnethercote

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2026
rust-bors Bot pushed a commit that referenced this pull request Apr 29, 2026
Rollup of 6 pull requests

Successful merges:

 - #152443 (NVPTX: Drop support for old architectures and old ISAs)
 - #155648 (`-Znext-solver` Propagate `stalled_on_coroutines` as a field in `Certainty::Maybe`)
 - #155896 (Shrink `ParseSess`)
 - #155922 (delete unused auxiliary test files)
 - #155943 (fix: ✏️ forgot to change the stable version for `assert_matches!` macro.)
 - #155947 (tests: mark simple UI tests as check-pass)
rust-timer added a commit that referenced this pull request Apr 29, 2026
Rollup merge of #155947 - SynapLink:cleanup/check-pass-variance-tests, r=nnethercote

tests: mark simple UI tests as check-pass

This changes 14 simple UI tests from build-pass to check-pass.

These tests cover type checking, trait bounds, closure inference, deprecation diagnostics, dyn compatibility, and variance. They do not need codegen or linking, so check-pass keeps the intended coverage while removing old FIXME(62277) markers.
@rust-bors rust-bors Bot merged commit 7ffff36 into rust-lang:main Apr 29, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants