Skip to content

fix: ✏️ forgot to change the stable version for assert_matches! macro.#155943

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
romancitodev:fix/version-mismatch
Apr 29, 2026
Merged

fix: ✏️ forgot to change the stable version for assert_matches! macro.#155943
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
romancitodev:fix/version-mismatch

Conversation

@romancitodev
Copy link
Copy Markdown
Contributor

@romancitodev romancitodev commented Apr 28, 2026 •
edited by rustbot
Loading

The assert_matches macro was delayed because of #154406 and the #[stable(since)] wasn't changed to the next version.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 28, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 28, 2026

r? @nia-e

rustbot has assigned @nia-e.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, nia-e, scottmcm

@romancitodev
Copy link
Copy Markdown
Contributor Author

romancitodev commented Apr 28, 2026

Btw, this is my first PR to this repo, so if I'm missing something (maybe changing the target), tell me!

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nia-e
Copy link
Copy Markdown
Member

nia-e commented Apr 28, 2026

See the build error (feature is likely mentioned elsewhere too), but happy to approve once that's fixed

@romancitodev
Copy link
Copy Markdown
Contributor Author

romancitodev commented Apr 28, 2026

Perfect! let me fix it.

@romancitodev
Copy link
Copy Markdown
Contributor Author

romancitodev commented Apr 28, 2026 •
edited
Loading

Because the error is error[E0711]: feature assert_matches is declared stable since 1.96.0, but was previously declared stable since 1.95.0 how it supposed to deal with it?

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jnkr-ifx
Copy link
Copy Markdown

jnkr-ifx commented Apr 28, 2026

Is this worth a beta backport, to stop stable docs for 1.96 from displaying the wrong stabilization version?

@nia-e
Copy link
Copy Markdown
Member

nia-e commented Apr 28, 2026

Think so. I intended to beta-nominate it once it's ready for merging

@nia-e nia-e added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 28, 2026
@nia-e
Copy link
Copy Markdown
Member

nia-e commented Apr 28, 2026

looks good :D

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

📌 Commit 910e2d2 has been approved by nia-e

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2026
@romancitodev
Copy link
Copy Markdown
Contributor Author

romancitodev commented Apr 28, 2026

yay :D

@ShoyuVanilla ShoyuVanilla mentioned this pull request Apr 29, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Apr 29, 2026
@bors
Auto merge of #155953 - ShoyuVanilla:rollup-BrmB2HL, r=ShoyuVanilla
4f9e4e1 
Rollup of 6 pull requests

Successful merges:

 - #152443 (NVPTX: Drop support for old architectures and old ISAs)
 - #155648 (`-Znext-solver` Propagate `stalled_on_coroutines` as a field in `Certainty::Maybe`)
 - #155896 (Shrink `ParseSess`)
 - #155922 (delete unused auxiliary test files)
 - #155943 (fix: ✏️ forgot to change the stable version for `assert_matches!` macro.)
 - #155947 (tests: mark simple UI tests as check-pass)
@rust-bors rust-bors Bot merged commit 44753d4 into rust-lang:main Apr 29, 2026
13 of 22 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 29, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 30, 2026

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 30, 2026
This was referenced Apr 30, 2026
Closed
Merged
@cuviper cuviper modified the milestones: 1.97.0, 1.96.0 Apr 30, 2026
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 30, 2026
rust-bors Bot pushed a commit that referenced this pull request May 1, 2026
@bors
Auto merge of #156011 - cuviper:beta-next, r=cuviper
72864ed 
[beta] backports

- Add temporary scope to assert_matches #155431
- fix: ✏️ forgot to change the stable version for `assert_matches!` macro. #155943
- codegen-options docs: remove -Csoft-float #155514
- `dlltool`: Set the working directory to workaround `--temp-prefix` bug #155899

r? cuviper
rust-bors Bot pushed a commit that referenced this pull request May 1, 2026
@bors
Auto merge of #156011 - cuviper:beta-next, r=cuviper
a5a9a54 
[beta] backports

- Add temporary scope to assert_matches #155431
- fix: ✏️ forgot to change the stable version for `assert_matches!` macro. #155943
- codegen-options docs: remove -Csoft-float #155514
- `dlltool`: Set the working directory to workaround `--temp-prefix` bug #155899

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nia-e nia-e

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

6 participants

@romancitodev @rustbot @rust-log-analyzer @nia-e @jnkr-ifx @cuviper