Skip to content

when bailing on ambiguity, don't force other results to ambig#155914

Open
lcnr wants to merge 1 commit intorust-lang:mainfrom
lcnr:search-graph-bail-on-ambig
Open

when bailing on ambiguity, don't force other results to ambig#155914
lcnr wants to merge 1 commit intorust-lang:mainfrom
lcnr:search-graph-bail-on-ambig

Conversation

@lcnr
Copy link
Copy Markdown
Contributor

@lcnr lcnr commented Apr 28, 2026 •
edited
Loading

a smaller version of #149904 which doesn't cause the perf issue in bevy, or at least in the minimization

Fixes rust-lang/trait-system-refactor-initiative#257, does not fix all of binius_field, the remaining issues are tracked in rust-lang/trait-system-refactor-initiative#274

r? BoxyUwU

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 28, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 28, 2026

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@lcnr
Copy link
Copy Markdown
Contributor Author

lcnr commented Apr 28, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 28, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Apr 28, 2026
@bors
Auto merge of #155914 - lcnr:search-graph-bail-on-ambig, r=<try>
6dcb6cd 
when bailing on ambiguity, don't force other results to ambig
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

☀️ Try build successful (CI)
Build commit: 6dcb6cd (6dcb6cdb85235ac3bf5e6e6ac173e11b5cf57ad2, parent: b806d39f033b05ea5aec9a353df75314007a728c)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 28, 2026

Finished benchmarking commit (6dcb6cd): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.8% [2.1%, 7.4%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.1% [0.0%, 0.2%] 49
Regressions ❌
(secondary)		 0.1% [0.0%, 0.2%] 23
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.1% [0.0%, 0.2%] 49

Bootstrap: 489.748s -> 489.291s (-0.09%)
Artifact size: 393.29 MiB -> 393.40 MiB (0.03%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 28, 2026
This was referenced Apr 30, 2026
Draft
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BoxyUwU BoxyUwU

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

global where-bounds normalization issue

4 participants

@lcnr @rustbot @rust-timer @BoxyUwU