Fix panic for doc attributes on where predicates#155864
Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom Apr 27, 2026
Merged
Fix panic for doc attributes on where predicates#155864rust-bors[bot] merged 3 commits intorust-lang:mainfrom
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
JonathanBrouwer
force-pushed
the
doc-attr-span
branch
from
f725871 to
3659ed9
Compare
JonathanBrouwer
commented
Apr 27, 2026
| //~^ ERROR most attributes are not supported in `where` clauses | ||
| ():, | ||
|
|
||
| // == That the doc attributes below don't trigger the error is a bug |
Contributor
Author
There was a problem hiding this comment.
This bug is not caused by this PR, but I did decide to document the bug in a test and I will make a follow-up PR to address it
JonathanBrouwer
force-pushed
the
doc-attr-span
branch
from
3467ed0 to
75fa098
Compare
GuillaumeGomez
approved these changes
Apr 27, 2026
Member
|
Neat, thanks! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 27, 2026
…uillaumeGomez Fix panic for doc attributes on where predicates Fixes rust-lang#155804 r? @GuillaumeGomez
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 27, 2026
…uillaumeGomez Fix panic for doc attributes on where predicates Fixes rust-lang#155804 r? @GuillaumeGomez
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
…uwer Rollup of 4 pull requests Successful merges: - #152487 (core: drop unmapped ZSTs in array `map`) - #155716 (arm64e: set ptrauth ABI subtype on lib.rmeta Mach-O objects) - #155864 (Fix panic for doc attributes on where predicates) - #155865 (add test for accidentally fixed `binius_field` issue)
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
…uwer Rollup of 6 pull requests Successful merges: - #154465 (triagebot: Mention 'subtree' in clippy message) - #155355 (Fix pathological performance in trait solver cycles with errors) - #155716 (arm64e: set ptrauth ABI subtype on lib.rmeta Mach-O objects) - #155864 (Fix panic for doc attributes on where predicates) - #155865 (add test for accidentally fixed `binius_field` issue) - #155866 (Render `ConstContext` for diagnostics once)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155804
r? @GuillaumeGomez