Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing ConstParamTy#155675
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 28, 2026
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
Collaborator
|
|
BoxyUwU
reviewed
Apr 24, 2026
| @@ -0,0 +1,27 @@ | |||
| //! Ensure that non exhaustive structs and enums with non exhaustive variants | |||
| //! aren't allowed to implement ConstParamTy | |||
| #![feature(min_adt_const_params)] | |||
Member
There was a problem hiding this comment.
can you make this test revisioned on whether full adt_const_params is enabled, and if it is this test should pass ✨
zedddie
force-pushed
the
disallow-non_exhaustive-adt-const-params
branch
from
ceeb9ec to
a12d329
Compare
…s from implementing `ConstParamTy`
zedddie
force-pushed
the
disallow-non_exhaustive-adt-const-params
branch
from
a12d329 to
33a1ed1
Compare
zedddie
commented
Apr 25, 2026
| //@ revisions: full min | ||
| //@[full] check-pass | ||
| #![cfg_attr(min, feature(min_adt_const_params))] | ||
| #![cfg_attr(full, feature(adt_const_params))] |
Contributor
Author
There was a problem hiding this comment.
not sure now, should it go into const-generics/adt_const_params or its fine as it is in min 🧐
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 27, 2026
…t-const-params, r=BoxyUwU Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing `ConstParamTy` tracking issue rust-lang#154042 r? BoxyUwU
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
…uwer Rollup of 9 pull requests Successful merges: - #155760 (Remove `AttributeLintKind`) - #154510 (Partially stabilize LoongArch target features) - #155137 (Allow trailing `self` in more contexts) - #155433 (Rip out rustc_layout_scalar_valid_range_* attribute support) - #155702 (Change `ItemKind::Trait` to a field variant.) - #154896 (Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder) - #155675 (Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing `ConstParamTy`) - #155874 (Avoid misleading closure return type note) - #155876 (CI: rfl: move job forward to Linux v7.1-rc1)
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
…uwer Rollup of 8 pull requests Successful merges: - #154510 (Partially stabilize LoongArch target features) - #155137 (Allow trailing `self` in more contexts) - #155513 (rustc_public: implement `Pattern` type) - #155702 (Change `ItemKind::Trait` to a field variant.) - #154896 (Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder) - #155675 (Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing `ConstParamTy`) - #155874 (Avoid misleading closure return type note) - #155876 (CI: rfl: move job forward to Linux v7.1-rc1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue #154042
r? BoxyUwU