compiler-builtins subtree update by folkertdev · Pull Request #155653 · rust-lang/rust

folkertdev · 2026-04-22T16:44:29Z

Subtree update of compiler-builtins to rust-lang/compiler-builtins@4d3ab86.

Created using https://github.com/rust-lang/josh-sync.

cc @tgross35 if this is not a good time to sync, but it looks like it's been a while and this should specifically close #153772

r? @ghost

The described issue in the reverted commit is no longer relevant. This reverts commit 870ab266bad7ec0a56abfc433f92e3c2d67a572c.

…publishing publish via trusted publishing

Resolve the following lints: * `unpinned-uses`: Pin action versions using `zizmor --fix` * `excessive-permissions`: Add `permissions: {}` to all workflows * `template-injection`: This one wasn't too concerning since `${{ ... }}` was only used for `matrix` and `needs` access, but it is easy enough to resolve by storing in an environment variable.

Based on the configuration for bors [1]. [1]: https://github.com/rust-lang/bors/blob/d89bfc24e8e7add3b03af3ab7307cd3b2a1af879/.github/renovate.json5

Resolve two cases of `ref-version-mismatch` and various `artipacked` instances.

Use the same trick as with other formatting implementations, which makes it possible to get rid of the awkward `-> String` functions.

Closes: rust-lang/compiler-builtins#1054

Add wrappers for compiler-builtins that closer match the libm interfaces, and add basic compiler-builtins float arithmetic to the set of tested functions. This means we now get tests against MPFR, better edge case coverage, extensive testing, and benchmarks for the following functions: * `__add[hsdt]f3` * `__sub[hsdt]f3` * `__mul[hsdt]f3` * `__div[sdt]f3` * `__powi[sdt]f2` Functions from compiler-builtins have not yet been tied in with `update-api-list.py` and the CI tooling that reads it, that will need to be updated in a follow up.

Add the following to our larger test infrastructure: * `__eq[hsdf]2` * `__ne[hsdf]2` * `__unord[hsdf]2` * `__lt[hsdf]2` * `__le[hsdf]2` * `__gt[hsdf]2` * `__ge[hsdf]2`

Add the following to the test infrastructure: * `__extenddftf2` * `__extendhfdf2` * `__extendhfsf2` * `__extendhftf2` * `__extendsfdf2` * `__extendsftf2` * `__truncdfhf2` * `__truncdfsf2` * `__truncsfhf2` * `__trunctfdf2` * `__trunctfhf2` * `__trunctfsf2`

Wire up benchmarks for functions that are now part of our testing infrastructure.

Create a new struct `Hex` that serves all of these purposes via a new trait `DisplayHex`. This is easier to work with because we can make `DisplayHex` a bound of `Float`.

This allows us to use a single base name for functions that have multiple types in the signature, such as `extend_f32_f64`. The compiler-builtins `trunc` operation wrappers had to be renamed to `narrow` to avoid conflicting with libm `trunc`.

Add the following to the test infrastructure: * `__fixdfdi` * `__fixdfsi` * `__fixdfti` * `__fixsfdi` * `__fixsfsi` * `__fixsfti` * `__fixtfdi` * `__fixtfsi` * `__fixtfti` * `__fixunsdfdi` * `__fixunsdfsi` * `__fixunsdfti` * `__fixunssfdi` * `__fixunssfsi` * `__fixunssfti` * `__fixunstfdi` * `__fixunstfsi` * `__fixunstfti`

The .dockerenv check was a workaround for Docker CI where the checkout is mounted read-only. However, its presence does not reliably indicate that the filesystem is unwritable. Use CARGO_TARGET_DIR as the condition instead, which directly captures when a custom writable target directory is in use and avoids false assumptions.

There isn't anything special about its implementation, so make it normal code to clean some things up.

Make it possible to access each argument without relying on `FTy`.

We can always access individual arguments rather than relying on the common `FTy` type. This is a cleaner design anyway since it handles functions with integers in the signature better.

Now that tests have moved to using argument types instead of a whole- function float type, remove `FTy` and its relevant configuration. This will make it possible to use the same infrastructure for functions that don't have any floats as arguments, or don't have any at all. Some uses of `FTy` have been replaced with the `Group` enum, e.g. for match arm patterns and selecting extensive tests. Anything that doesn't have float types in the signature will be in the `Integer` category.

tgross35 · 2026-04-22T22:16:54Z

Wow that's a lot of commits since the last sync. Feel free to poke me on these if you're waiting on something, didn't realize it had been so long.

Hmm, the compilation complains about the mem feature not being available. Looks like the comment was updated but then the feature was removed in

2257936#diff-3a38a19226bdfa7d6023644ec99a02fe6326602d053283e44aac342ee74a50af

does it need to be added back, or should we remove uses of it?

Could you add a commit adding it back to library/compiler-builtins/compiler-builtins/Cargo.toml under the comment? That's the manifest that gets used in r-l/r and should match library/compiler-builtins/builtins-shim/Cargo.toml, but looks like I messed it up there.

this was removed by accident before, and only discovered now that we're syncing with the main repo

folkertdev · 2026-04-22T23:26:20Z

Wow that's a lot of commits since the last sync.

I think it's mostly bookkeeping for that repo, so it looks like more than it actually is. But there are some useful fixes in there.

Could you add a commit adding it back to library/compiler-builtins/compiler-builtins/Cargo.toml under the comment?

Done, hopefully that is sufficient (please r+ if this passes CI, otherwise I'll get back to it in the morning)

tgross35 · 2026-04-22T23:41:58Z

Yeah I've been doing a ton of testing changes there recently, not so much implementation work. Still just has to be a record for the count and for the +/-.

Done, hopefully that is sufficient (please r+ if this passes CI, otherwise I'll get back to it in the morning)

Will do, was already planning on it 👍

tgross35

@bors r+ rollup=never

View changes since this review

rust-bors · 2026-04-22T23:57:51Z

📌 Commit ca43552 has been approved by tgross35

It is now in the queue for this repository.

@tgross35

… r=tgross35 compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@4d3ab86. Created using https://github.com/rust-lang/josh-sync. cc @tgross35 if this is not a good time to sync, but it looks like it's been a while and this should specifically close #153772 r? @ghost

rust-log-analyzer · 2026-04-23T21:47:13Z

The job dist-various-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   |
38 | #[cfg(mem_unaligned)]
   |       ^^^^^^^^^^^^^
   |
   = help: expected names are: `__aarch64_cas16_acq`, `__aarch64_cas16_acq_rel`, `__aarch64_cas16_rel`, `__aarch64_cas16_relax`, `__aarch64_cas1_acq`, `__aarch64_cas1_acq_rel`, `__aarch64_cas1_rel`, `__aarch64_cas1_relax`, `__aarch64_cas2_acq`, `__aarch64_cas2_acq_rel`, `__aarch64_cas2_rel`, `__aarch64_cas2_relax`, `__aarch64_cas4_acq`, `__aarch64_cas4_acq_rel`, `__aarch64_cas4_rel`, `__aarch64_cas4_relax`, `__aarch64_cas8_acq`, `__aarch64_cas8_acq_rel`, `__aarch64_cas8_rel`, `__aarch64_cas8_relax`, `__aarch64_ldadd1_acq`, `__aarch64_ldadd1_acq_rel`, `__aarch64_ldadd1_rel`, `__aarch64_ldadd1_relax`, `__aarch64_ldadd2_acq`, `__aarch64_ldadd2_acq_rel`, `__aarch64_ldadd2_rel`, `__aarch64_ldadd2_relax`, `__aarch64_ldadd4_acq`, `__aarch64_ldadd4_acq_rel`, `__aarch64_ldadd4_rel`, `__aarch64_ldadd4_relax`, `__aarch64_ldadd8_acq`, `__aarch64_ldadd8_acq_rel`, and `__aarch64_ldadd8_rel` and 132 more
   = help: consider using a Cargo feature instead
   = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
            [lints.rust]
            unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mem_unaligned)'] }
   = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mem_unaligned)");` to the top of the `build.rs`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
   = note: `#[warn(unexpected_cfgs)]` on by default

warning: unexpected `cfg` condition name: `mem_unaligned`
  --> /rustc/8c8061eb41ac30d99092f067fa93b30212a034ab/library/compiler-builtins/compiler-builtins/src/mem/impls.rs:49:11
   |
49 | #[cfg(not(mem_unaligned))]
   |           ^^^^^^^^^^^^^
   |
   = help: consider using a Cargo feature instead
   = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
            [lints.rust]
            unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mem_unaligned)'] }
   = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mem_unaligned)");` to the top of the `build.rs`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition name: `mem_unaligned`
  --> /rustc/8c8061eb41ac30d99092f067fa93b30212a034ab/library/compiler-builtins/compiler-builtins/src/mem/impls.rs:69:11
   |
69 | #[cfg(not(mem_unaligned))]
   |           ^^^^^^^^^^^^^
   |
   = help: consider using a Cargo feature instead
   = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
            [lints.rust]
            unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mem_unaligned)'] }
   = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mem_unaligned)");` to the top of the `build.rs`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition name: `mem_unaligned`
  --> /rustc/8c8061eb41ac30d99092f067fa93b30212a034ab/library/compiler-builtins/compiler-builtins/src/mem/impls.rs:91:11
   |
91 | #[cfg(not(mem_unaligned))]
   |           ^^^^^^^^^^^^^
   |
   = help: consider using a Cargo feature instead
   = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
            [lints.rust]
            unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mem_unaligned)'] }
   = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mem_unaligned)");` to the top of the `build.rs`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition name: `mem_unaligned`
   --> /rustc/8c8061eb41ac30d99092f067fa93b30212a034ab/library/compiler-builtins/compiler-builtins/src/mem/impls.rs:139:15
    |
139 |     #[cfg(not(mem_unaligned))]
    |               ^^^^^^^^^^^^^
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mem_unaligned)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mem_unaligned)");` to the top of the `build.rs`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition name: `mem_unaligned`
   --> /rustc/8c8061eb41ac30d99092f067fa93b30212a034ab/library/compiler-builtins/compiler-builtins/src/mem/impls.rs:188:11
    |
188 |     #[cfg(mem_unaligned)]
    |           ^^^^^^^^^^^^^
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mem_unaligned)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mem_unaligned)");` to the top of the `build.rs`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition name: `mem_unaligned`
   --> /rustc/8c8061eb41ac30d99092f067fa93b30212a034ab/library/compiler-builtins/compiler-builtins/src/mem/impls.rs:255:15
    |
255 |     #[cfg(not(mem_unaligned))]
    |               ^^^^^^^^^^^^^
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mem_unaligned)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mem_unaligned)");` to the top of the `build.rs`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition name: `mem_unaligned`
   --> /rustc/8c8061eb41ac30d99092f067fa93b30212a034ab/library/compiler-builtins/compiler-builtins/src/mem/impls.rs:304:11
    |
304 |     #[cfg(mem_unaligned)]
    |           ^^^^^^^^^^^^^
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(mem_unaligned)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(mem_unaligned)");` to the top of the `build.rs`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

   Compiling rustc-std-workspace-core v1.99.0 (/checkout/library/rustc-std-workspace-core)
   Compiling alloc v0.0.0 (/checkout/library/alloc)
[RUSTC-TIMING] rustc_std_workspace_core test:false 0.036

rust-bors · 2026-04-23T21:48:12Z

💔 Test for 8c8061e failed: CI. Failed job:

auto - dist-various-1 (web logs, enhanced plaintext logs)

tgross35 · 2026-04-23T21:51:00Z

I'll have a patch ready shortly

tgross35 · 2026-04-24T00:33:44Z

I can't push this branch, testing in #155709

…=tgross35 compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@4d3ab86. Created using https://github.com/rust-lang/josh-sync. Closes: #155653

rust-bors · 2026-04-24T13:55:05Z

This pull request was unapproved due to being closed.

…=tgross35 compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang@4d3ab86. Created using https://github.com/rust-lang/josh-sync. Closes: rust-lang/rust#155653

…=tgross35 compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@4d3ab86. Created using https://github.com/rust-lang/josh-sync. Closes: rust-lang/rust#155653

tgross35 and others added 30 commits March 15, 2026 17:30

ci: Bump all actions to latest

7463a85

publish via trusted publishing

8d51ad1

export __mulsi3 on m68k

f638250

Revert "ci: Pin Miri to the 2026-02-11 nightly"

d723253

The described issue in the reverted commit is no longer relevant. This reverts commit 870ab266bad7ec0a56abfc433f92e3c2d67a572c.

Merge pull request rust-lang#1112 from marcoieni/publish-via-trusted-…

7e44508

…publishing publish via trusted publishing

ci: Add configuration for renovatebot (rust-lang#1114)

549b6d7

Based on the configuration for bors [1]. [1]: https://github.com/rust-lang/bors/blob/d89bfc24e8e7add3b03af3ab7307cd3b2a1af879/.github/renovate.json5

Add zizmor to check Github Actions (static analysis)

741b5e9

ci: Resolve audit issues reported by zizmore

41a6f3e

Resolve two cases of `ref-version-mismatch` and various `artipacked` instances.

libm: fix test for overflow in u256::shr

d552a7c

libm: Remove hexu in favor of formatting traits on u256

74955ac

Use the same trick as with other formatting implementations, which makes it possible to get rid of the awkward `-> String` functions.

ci: update nextest to 0.9.131 with install-action

43b30e8

ci: Test on riscv64 using a self-hosted runner

ca309a4

Closes: rust-lang/compiler-builtins#1054

meta: Cover both .yaml and .yml in .editorconfig

16cb481

ci: Move matrix.os comparisons to an environment variable

5ac9393

test: Better support tests that don't require a ulp value

e8e3bdd

test: Clean up macro use in builtins_wrappers

b6331ad

test: Cover compiler-builtins float comparison in libm-test

178cea5

Add the following to our larger test infrastructure: * `__eq[hsdf]2` * `__ne[hsdf]2` * `__unord[hsdf]2` * `__lt[hsdf]2` * `__le[hsdf]2` * `__gt[hsdf]2` * `__ge[hsdf]2`

macros: Update skip_f16_f128 to handle return types

456bf77

test: Add benchmarks for c-b functions covered in libm-test

3cef40c

Wire up benchmarks for functions that are now part of our testing infrastructure.

test: Consolidate Hexf, Hexi, and the Hex trait

5650d08

Create a new struct `Hex` that serves all of these purposes via a new trait `DisplayHex`. This is easier to work with because we can make `DisplayHex` a bound of `Float`.

test: Move the math_op function out of macro code

0adf2b3

There isn't anything special about its implementation, so make it normal code to clean some things up.

test: Introduce a helper trait for tuple type access

383ddd1

Make it possible to access each argument without relying on `FTy`.

test: Migrate from using FTy to accessing individual arguments

495d1e8

We can always access individual arguments rather than relying on the common `FTy` type. This is a cleaner design anyway since it handles functions with integers in the signature better.

add the mem feature back to compiler-builtins/Cargo.toml

ca43552

this was removed by accident before, and only discovered now that we're syncing with the main repo

tgross35 approved these changes Apr 22, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 23, 2026

tgross35 mentioned this pull request Apr 24, 2026

compiler-builtins subtree update #155709

Merged

rust-bors Bot closed this in ec6f9a5 Apr 24, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 24, 2026

rust-bors Bot merged commit ca43552 into rust-lang:main Apr 24, 2026
11 of 12 checks passed

cuviper added this to the 1.97.0 milestone Apr 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

compiler-builtins subtree update#155653

compiler-builtins subtree update#155653
rust-bors[bot] merged 120 commits intorust-lang:mainfrom
folkertdev:compiler-builtins-sync-2026-04-22

folkertdev commented Apr 22, 2026

Uh oh!

tgross35 commented Apr 22, 2026

Uh oh!

folkertdev commented Apr 22, 2026

Uh oh!

tgross35 commented Apr 22, 2026

Uh oh!

tgross35 left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Apr 22, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Apr 23, 2026

Uh oh!

rust-bors Bot commented Apr 23, 2026

Uh oh!

tgross35 commented Apr 23, 2026

Uh oh!

tgross35 commented Apr 24, 2026

Uh oh!

Uh oh!

rust-bors Bot commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Uh oh!

Conversation

folkertdev commented Apr 22, 2026

Uh oh!

tgross35 commented Apr 22, 2026

Uh oh!

folkertdev commented Apr 22, 2026

Uh oh!

tgross35 commented Apr 22, 2026

Uh oh!

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Apr 22, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Apr 23, 2026

Uh oh!

rust-bors Bot commented Apr 23, 2026

Uh oh!

tgross35 commented Apr 23, 2026

Uh oh!

tgross35 commented Apr 24, 2026

Uh oh!

Uh oh!

rust-bors Bot commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

tgross35 left a comment •

edited by rustbot

Loading