-Znext-solver Propagate stalled_on_coroutines as a field in Certainty::Maybe#155648
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 29, 2026
Merged
Conversation
rustbot
added
S-waiting-on-author
Member
Author
|
r? lcnr |
rustbot
added
the
S-waiting-on-review
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rustbot
removed
the
S-waiting-on-author
Contributor
|
let's see @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
…<try> `-Znext-solver` Propagate `stalled_on_coroutines` as a field in `Certainty::Maybe`
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (383ff9d): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 5.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 488.817s -> 488.152s (-0.14%) |
rustbot
removed
the
S-waiting-on-perf
lcnr
reviewed
Apr 27, 2026
ShoyuVanilla
force-pushed
the
maybe-stalled-on-couroutines
branch
from
3dd7f0f to
58572ce
Compare
Collaborator
|
Some changes occurred in src/tools/cargo cc @ehuss |
This comment has been minimized.
This comment has been minimized.
ShoyuVanilla
force-pushed
the
maybe-stalled-on-couroutines
branch
from
58572ce to
97868eb
Compare
Member
Author
|
Oh, sorry. I accidently pushed cargo submodule 😢 |
lcnr
reviewed
Apr 27, 2026
lcnr
reviewed
Apr 27, 2026
ShoyuVanilla
force-pushed
the
maybe-stalled-on-couroutines
branch
from
97868eb to
7ba46ec
Compare
lcnr
reviewed
Apr 27, 2026
lcnr
reviewed
Apr 27, 2026
lcnr
reviewed
Apr 27, 2026
ShoyuVanilla
force-pushed
the
maybe-stalled-on-couroutines
branch
2 times, most recently
from
1d8941d to
b29d6e9
Compare
lcnr
reviewed
Apr 28, 2026
Comment on lines
+161
to
+165
| self.evaluate_added_goals_and_make_canonical_response(Certainty::Maybe(MaybeInfo { | ||
| cause: MaybeCause::Ambiguity, | ||
| opaque_types_jank: OpaqueTypesJank::AllGood, | ||
| }) | ||
| stalled_on_coroutines: StalledOnCoroutines::No, | ||
| })) |
Contributor
There was a problem hiding this comment.
Suggested change
| self.evaluate_added_goals_and_make_canonical_response(Certainty::Maybe(MaybeInfo { | |
| cause: MaybeCause::Ambiguity, | |
| opaque_types_jank: OpaqueTypesJank::AllGood, | |
| }) | |
| stalled_on_coroutines: StalledOnCoroutines::No, | |
| })) | |
| self.evaluate_added_goals_and_make_canonical_response(Certainty::AMBIGUOUS) |
Member
Author
There was a problem hiding this comment.
Oh, I missed this 😅
lcnr
reviewed
Apr 28, 2026
ShoyuVanilla
force-pushed
the
maybe-stalled-on-couroutines
branch
from
b29d6e9 to
25c241c
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=lcnr |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 29, 2026
Rollup of 6 pull requests Successful merges: - #152443 (NVPTX: Drop support for old architectures and old ISAs) - #155648 (`-Znext-solver` Propagate `stalled_on_coroutines` as a field in `Certainty::Maybe`) - #155896 (Shrink `ParseSess`) - #155922 (delete unused auxiliary test files) - #155943 (fix: ✏️ forgot to change the stable version for `assert_matches!` macro.) - #155947 (tests: mark simple UI tests as check-pass)
rust-timer
added a commit
that referenced
this pull request
Apr 29, 2026
Rollup merge of #155648 - ShoyuVanilla:maybe-stalled-on-couroutines, r=lcnr `-Znext-solver` Propagate `stalled_on_coroutines` as a field in `Certainty::Maybe` ..instead of collecting them with a `ProofTreeVisitor` Fixes rust-lang/trait-system-refactor-initiative#270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
..instead of collecting them with a
ProofTreeVisitorFixes rust-lang/trait-system-refactor-initiative#270