Skip to content

add warning message when using x fix#155554

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
nivekithan:issue-155545-fix
Apr 21, 2026
Merged

add warning message when using x fix#155554
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
nivekithan:issue-155545-fix

Conversation

@nivekithan
Copy link
Copy Markdown
Contributor

@nivekithan nivekithan commented Apr 20, 2026

Fix for issue: #155545

Before:
image

After:
image

Text added

WARNING: `x fix` is provided on a best-effort basis and does not support all `cargo fix` options correctly.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 20, 2026

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 20, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 20, 2026

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 21, 2026

cc @jyn514 (if you'd like i can delegate r+ for this one)

@jyn514
Copy link
Copy Markdown
Member

jyn514 commented Apr 21, 2026

@Kivooeo please do, thanks :)

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 21, 2026

@bors delegate=jyn514

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 21, 2026

Invalid command: Invalid delegation type jyn514. Possible values are try/review. Run @bors help to see available commands.

@jyn514
Copy link
Copy Markdown
Member

jyn514 commented Apr 21, 2026

introducing a new type of PR: jyn PRs

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 21, 2026

ok let's just do this since you are alumni in bootstrap team, i guess no one would have complains on that

r? jyn514

@bors r=jyn514 rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 21, 2026

📌 Commit 440ed80 has been approved by jyn514

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 21, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 21, 2026

jyn514 is not on the review rotation at the moment.
They may take a while to respond.

@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 21, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Apr 21, 2026
@bors
Auto merge of #155599 - JonathanBrouwer:rollup-cI1hRiI, r=JonathanBro…
d2f88d4 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #152611 (Modify error message of importing inherent associated items when `#[feature(import_trait_associated_functions)]` is enabled)
 - #155359 (Improperctypes refactor2.2)
 - #155036 (Store a PathBuf rather than SerializedModule for cached modules)
 - #155554 (add warning message when using x fix)
rust-timer added a commit that referenced this pull request Apr 21, 2026
@rust-timer
Unrolled build for #155554
7497b4f 
Rollup merge of #155554 - nivekithan:issue-155545-fix, r=jyn514

add warning message when using x fix

Fix for issue: #155545

Before:
<img width="1880" height="329" alt="image" src="https://github.com/user-attachments/assets/b713d940-f229-4c63-8df8-93634f017793" />

After:
<img width="1897" height="387" alt="image" src="https://github.com/user-attachments/assets/5bbca701-b319-45ca-9d46-39847c50b6f8" />

Text added

```
WARNING: `x fix` is provided on a best-effort basis and does not support all `cargo fix` options correctly.
```
@rust-bors rust-bors Bot merged commit e150483 into rust-lang:main Apr 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 21, 2026
@reddevilmidzy reddevilmidzy mentioned this pull request Apr 22, 2026
Closed
@reddevilmidzy
Copy link
Copy Markdown
Member

reddevilmidzy commented Apr 22, 2026

Hello @nivekithan
If you add close #{issue_number} to the PR description, the issue will be automatically closed when the PR is merged.

https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jyn514 jyn514 jyn514 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jyn514 jyn514

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nivekithan @rustbot @Kivooeo @jyn514 @reddevilmidzy @clubby789