Document panic in `RangeInclusive::from(legacy::RangeInclusive)` by tbu- · Pull Request #155421 · rust-lang/rust

tbu- · 2026-04-17T07:51:47Z

No description provided.

rustbot · 2026-04-17T07:51:53Z

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @scottmcm, libs
@scottmcm, libs expanded to 7 candidates
Random selection from Mark-Simulacrum, jhpratt, scottmcm

jhpratt · 2026-04-17T07:54:48Z

Has this been approved by T-libs-api? The panic message clearly says unspecified, so adding this documentation would overrule that.

tbu- · 2026-04-17T08:05:02Z

If T-libs doesn't want to guarantee this, I can change the wording to "currently panics, may not panic in the future". Or even "may panic".

fmease · 2026-04-17T08:39:56Z

#155394

Amanieu · 2026-04-27T23:08:23Z

ping @tbu-, CI is failing. You need to add #![feature(new_range_api_legacy)] to the doc tests or import the old range types from core::ops instead.

tbu- · 2026-04-28T15:09:08Z

Thanks for the ping, @Amanieu. I somehow forgot about this PR.

theemathas · 2026-04-29T05:32:13Z

Note: The current status of the PR adds a new stable guarantee that the conversion will panic for an exhausted iterator.

rustbot assigned jhpratt Apr 17, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 17, 2026