Document panic behavior of RangeInclusive's From impl#155394
Open
theemathas wants to merge 1 commit intorust-lang:mainfrom
Open
Document panic behavior of RangeInclusive's From impl#155394theemathas wants to merge 1 commit intorust-lang:mainfrom
RangeInclusive's From impl#155394theemathas wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
theemathas
force-pushed
the
range-inclusive-from-panic-docs
branch
from
eb1bedc to
ae6722b
Compare
Contributor
|
Sorry, I hadn't looked for duplicates when I wrote my PR #155421. Since mine has a bit more documentation, I'd prefer to see mine merged. |
Member
|
My preference is towards merging #155421, but that one is currently failing CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion on zulip, this was intentional.
r? libs-api