fix issue-144595#155375
Draft
bb1yd wants to merge 2 commits intorust-lang:mainfrom
Draft
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
I reimplement it by create a snapshot parser when there is a colon in the field (see the second commit). When the type parse failed, the code will try to parse the field again using the snapshot parser. But this method also has a problem. I use 'parse_name_and_ty' to parse the field again, and this function might emit errors internally rather than return it for the caller to cancel. error: found single colon in a struct field type path
--> ./test.rs:1:25
|
1 | struct Foo(a:std::string:String);
| ^
|
help: write a path separator here
|
1 | struct Foo(a:std::string::String);
| +
error: expected one of `!`, `(`, `+`, `,`, `::`, or `<`, found `:`
--> ./test.rs:1:13
|
1 | struct Foo(a:std::string:String);
| ^ expected one of `!`, `(`, `+`, `,`, `::`, or `<`
|
help: if you wanted to create a tuple struct, remove field names:
--> ./test.rs:1:12
|
1 | struct Foo(a:std::string:String);
| --
help: if you wanted to create a regular struct, use curly braces:
|
1 - struct Foo(a:std::string:String);
1 + struct Foo{a:std::string:String}
|
error: expected one of `!`, `(`, `)`, `+`, `,`, `::`, or `<`, found `:`
--> ./test.rs:1:25
|
1 | struct Foo(a:std::string:String);
| ^ expected one of 7 possible tokens
error: aborting due to 3 previous errorsI think I need some help. |
Contributor
Author
|
r? compiler |
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relevant issue:#144595
I implement this issue by simply find every colon in the tuple struct.
This method has a problem that it might mislead the user when the user type something like
struct Foo(std::string:String);(accidentally type :: as :). The compiler will print:I'm not sure if this is acceptable. Maybe a better way is to parse the field as a record struct field again.