BufReader: Clarify comment that makes a subtly wrong implication.#155316
Open
briansmith wants to merge 1 commit intorust-lang:mainfrom
Open
BufReader: Clarify comment that makes a subtly wrong implication.#155316briansmith wants to merge 1 commit intorust-lang:mainfrom
briansmith wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Mark-Simulacrum
requested changes
Apr 26, 2026
Member
There was a problem hiding this comment.
Can we reword the phrasing here to reflect this is a bool and so "same as filled" does not make much sense?
rustbot
removed
the
S-waiting-on-review
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
briansmith
force-pushed
the
b/bufreader-filled-comment
branch
from
b949ca0 to
3362bf1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The comment for `filled` implies that only `fill_buf` writes to `filled`, but that isn't true.
briansmith
force-pushed
the
b/bufreader-filled-comment
branch
from
3362bf1 to
de942d9
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implication is that only
fill_bufwrites tofilled, but that isn't true.