Skip to content

doc(core::cmp::Eq): fix definition of symmetry#155313

Open
numero-744 wants to merge 1 commit intorust-lang:mainfrom
numero-744:patch-1
Open

doc(core::cmp::Eq): fix definition of symmetry#155313
numero-744 wants to merge 1 commit intorust-lang:mainfrom
numero-744:patch-1

Conversation

@numero-744
Copy link
Copy Markdown

The definition did not match the one from PartialEq

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 14, 2026

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, ibraheemdev, scottmcm

@numero-744
Copy link
Copy Markdown
Author

Here is the documentation from PartialEq

/// Implementations must ensure that `eq` and `ne` are consistent with each other:
///
/// - `a != b` if and only if `!(a == b)`.

The pointed equivalence is not related to symmetry here. Should I move it out from the symmetry bullet point in Eq as well?

@quaternic
Copy link
Copy Markdown
Contributor

Yes, it is indeed unrelated. You could move it to a separate bullet point, maybe consistency.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 20, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

The definition did not match the one from PartialEq
and was merged with the definition of symmetry.
@numero-744
Copy link
Copy Markdown
Author

I had one job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants