add the fma4 x86 target feature#155235
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 14, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
fma4-target-feature
branch
from
cf63b92 to
c766242
Compare
Contributor
|
LGTM @bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
…uwer Rollup of 7 pull requests Successful merges: - #154049 (delegation: Track more precise spans for glob delegations) - #155134 (Replace custom trim_ascii_start with the standard library method) - #155235 (add the `fma4` x86 target feature) - #155218 (coroutines: Skip the closure signature annotation check for tainted bodies) - #155274 (limit duplicate-profiler-builtins test to targets that can do dynamic linking) - #155276 (`#[rustc_must_match_exhaustively]` detect let else) - #155281 (Revert "allow `windows-gnu` targets to embed gdb visualizer scripts")
rust-timer
added a commit
that referenced
this pull request
Apr 14, 2026
Rollup merge of #155235 - folkertdev:fma4-target-feature, r=sayantn add the `fma4` x86 target feature tracking issue: #155233 Implications are based on LLVM https://github.com/llvm/llvm-project/blob/df6c82053c5e1f9814d130d423f34871bc6423c5/llvm/lib/Target/X86/X86.td#L201-L206 This feature adds a slightly better instruction encoding for fma. We might want to expose the intrinsics in `stdarch` with that target feature, but just adding the target feature in user code should already take advantage of this improved encoding. This target feature is used in `libm`. r? sayantn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #155233
Implications are based on LLVM
https://github.com/llvm/llvm-project/blob/df6c82053c5e1f9814d130d423f34871bc6423c5/llvm/lib/Target/X86/X86.td#L201-L206
This feature adds a slightly better instruction encoding for fma. We might want to expose the intrinsics in
stdarchwith that target feature, but just adding the target feature in user code should already take advantage of this improved encoding.This target feature is used in
libm.r? sayantn