Ensure Send/Sync impl for std::process::CommandArgs#155113
Open
Mark-Simulacrum wants to merge 1 commit intorust-lang:mainfrom
Open
Ensure Send/Sync impl for std::process::CommandArgs#155113Mark-Simulacrum wants to merge 1 commit intorust-lang:mainfrom
Mark-Simulacrum wants to merge 1 commit intorust-lang:mainfrom
Conversation
Mark-Simulacrum
added
T-libs-api
rustbot
added
the
S-waiting-on-author
Mark-Simulacrum
force-pushed
the
auto-trait-cmd
branch
from
b60befa to
c08e6e4
Compare
Collaborator
|
@Mark-Simulacrum: no appropriate reviewer found, use |
rustbot
added
S-waiting-on-review
Mark-Simulacrum
added
the
S-waiting-on-t-libs-api
Member
|
@rfcbot merge libs-api |
Collaborator
|
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rust-rfcbot
added
proposed-final-comment-period
the8472
removed
needs-fcp
rust-rfcbot
added
final-comment-period
Collaborator
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds static assertions to ensure this continues to hold across all targets. I think today this was just missing on cfg(unix) targets, but haven't checked too thoroughly. I think all tier 2+ targets continue to compile with the assertions (but we'll see what CI says).
cc #154517