Move and clean up some ui test#155081
Merged
rust-bors[bot] merged 5 commits intorust-lang:mainfrom Apr 24, 2026
Merged
Conversation
reddevilmidzy
commented
Apr 10, 2026
Comment on lines
-1
to
-5
| //@ run-pass | ||
| //@ compile-flags: -D warnings -D unknown-lints | ||
|
|
||
| #![allow(unknown_lints)] | ||
| #![allow(random_lint_name)] |
Member
Author
There was a problem hiding this comment.
This test is a regression test of this #54737
Upon checking in version 1.21, the same issue occurred even for cases on a single line like tests/ui/lint/unknown-lints/allow-unknown-unstable-lint-inline.rs, so I deleted it
5c5d0d0 to
7c23ee6
Compare
Member
Author
|
Hello @Kivooeo, Could you review this when you have time? |
Kivooeo
approved these changes
Apr 24, 2026
Member
|
@bors r+ rollup |
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 24, 2026
Move and clean up some ui test `ui/reserved` -> `ui/keyword` `ui/deref-patterns` -> `ui/pattern/deref-patterns` `ui/unknown-unstable-lints` -> `ui/lint/unknown-lints` Tests related to unknown_lints that were located above lint have also been moved to a subdirectory, and duplicate tests have been deleted. And delete unnecessary `//@ check-fail` r? Kivooeo
This was referenced Apr 24, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 24, 2026
Rollup of 9 pull requests Successful merges: - #155684 (Generalize IO Traits for `Arc<T>` where `&T: IoTrait`) - #155081 (Move and clean up some ui test) - #155379 (Avoid query cycles in DataflowConstProp) - #155663 (Eliminate `CrateMetadataRef`.) - #155669 (Add `Sender` diagnostic item for `std::sync::mpsc::Sender`) - #155698 (Syntactically reject tuple index shorthands in struct patterns to fix a correctness regression) - #155703 (Remove myself as a maintainer of `wasm32-wasip1-threads`) - #155706 (Remove `AttributeLintKind` variants - part 7) - #155712 (Forbid `*-pass` and `*-fail` directives in tests/crashes)
rust-timer
added a commit
that referenced
this pull request
Apr 24, 2026
Rollup merge of #155081 - reddevilmidzy:ui-fixme, r=Kivooeo Move and clean up some ui test `ui/reserved` -> `ui/keyword` `ui/deref-patterns` -> `ui/pattern/deref-patterns` `ui/unknown-unstable-lints` -> `ui/lint/unknown-lints` Tests related to unknown_lints that were located above lint have also been moved to a subdirectory, and duplicate tests have been deleted. And delete unnecessary `//@ check-fail` r? Kivooeo
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Apr 27, 2026
Rollup of 9 pull requests Successful merges: - rust-lang/rust#155684 (Generalize IO Traits for `Arc<T>` where `&T: IoTrait`) - rust-lang/rust#155081 (Move and clean up some ui test) - rust-lang/rust#155379 (Avoid query cycles in DataflowConstProp) - rust-lang/rust#155663 (Eliminate `CrateMetadataRef`.) - rust-lang/rust#155669 (Add `Sender` diagnostic item for `std::sync::mpsc::Sender`) - rust-lang/rust#155698 (Syntactically reject tuple index shorthands in struct patterns to fix a correctness regression) - rust-lang/rust#155703 (Remove myself as a maintainer of `wasm32-wasip1-threads`) - rust-lang/rust#155706 (Remove `AttributeLintKind` variants - part 7) - rust-lang/rust#155712 (Forbid `*-pass` and `*-fail` directives in tests/crashes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui/reserved->ui/keywordui/deref-patterns->ui/pattern/deref-patternsui/unknown-unstable-lints->ui/lint/unknown-lintsTests related to unknown_lints that were located above lint have also been moved to a subdirectory, and duplicate tests have been deleted.
And delete unnecessary
//@ check-failr? Kivooeo