Skip to content

Error on projection of dyn noncompat type in old trait solver#154992

Open
spirali wants to merge 1 commit intorust-lang:mainfrom
spirali:fix-dyn-projection
Open

Error on projection of dyn noncompat type in old trait solver#154992
spirali wants to merge 1 commit intorust-lang:mainfrom
spirali:fix-dyn-projection

Conversation

@spirali
Copy link
Copy Markdown
Contributor

@spirali spirali commented Apr 8, 2026 •
edited by rustbot
Loading

View all comments

Trying to fix rust-lang/trait-system-refactor-initiative#269

I am not sure that the check is placed into the right place in the code.

r? lcnr

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 8, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 8, 2026
lcnr
lcnr reviewed Apr 9, 2026
View reviewed changes
Comment thread tests/ui/self/dispatch-dyn-incompatible-that-does-not-deref.rs
//~^ ERROR the trait `Foo` is not dyn compatible
x.method();
//~^ ERROR the trait `Foo` is not dyn compatible
//~^ ERROR no method named `method` found for reference `&dyn Foo`
Copy link
Copy Markdown
Contributor

@lcnr lcnr Apr 9, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View changes since the review

that's annoying :< ideally we'd silence method errors if the self type is not well-formed, tracking that is non-trivial and I don't know how we'd do so myself rn

@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 9, 2026

lgtm, let's do a crater run, there should be exactly 1 regression from this

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Apr 9, 2026
@bors
Auto merge of #154992 - spirali:fix-dyn-projection, r=<try>
a611f2a 
Error on projection of dyn noncompat type in old trait solver
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 9, 2026

☀️ Try build successful (CI)
Build commit: a611f2a (a611f2a14e38407ec6717a86a01424ee6fc80762, parent: 1fe72d35998dea48aeecaf7fc07783b0b553f24f)

@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 9, 2026

@craterbot check

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 9, 2026

👌 Experiment pr-154992 created and queued.
🤖 Automatically detected try build a611f2a
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2026
@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 20, 2026

🚧 Experiment pr-154992 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 22, 2026

🎉 Experiment pr-154992 is completed!
📊 18 regressed and 6 fixed (886019 total)
📊 5676 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-154992/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 22, 2026
@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 27, 2026

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-154992/retry-regressed-list.txt

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 27, 2026

👌 Experiment pr-154992-1 created and queued.
🤖 Automatically detected try build a611f2a
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2026
@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 27, 2026

@craterbot p=1

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 27, 2026

📝 Configuration of the pr-154992-1 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 27, 2026

🚧 Experiment pr-154992-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 27, 2026

🎉 Experiment pr-154992-1 is completed!
📊 13 regressed and 0 fixed (5381 total)
📊 968 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-154992-1/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 27, 2026
@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Apr 29, 2026

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-154992-1/retry-regressed-list.txt p=1

surprising that we have that many spurious regressions still?

it's caused by build OOMs and unlike the new solver, this PR shouldn't really change max-rss in any way 😅 cc @rust-lang/infra

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 29, 2026

👌 Experiment pr-154992-2 created and queued.
🤖 Automatically detected try build a611f2a
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2026
@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Apr 29, 2026
@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 29, 2026

🚧 Experiment pr-154992-2 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented Apr 30, 2026

🎉 Experiment pr-154992-2 is completed!
📊 12 regressed and 0 fixed (981 total)
📊 777 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-154992-2/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 30, 2026
@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented May 5, 2026

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-154992-2/retry-regressed-list.txt p=1

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented May 5, 2026

👌 Experiment pr-154992-3 created and queued.
🤖 Automatically detected try build a611f2a
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@lcnr lcnr

Labels

S-waiting-on-crater Status: Waiting on a crater run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

old solver: check dyn compatability when normalizing

4 participants

@spirali @lcnr @craterbot @rustbot