Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder#154896
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 28, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
TaKO8Ki
reviewed
Apr 21, 2026
cijiugechu
force-pushed
the
fix-unsafe-binder-layout-ice
branch
from
7f93670 to
dface0a
Compare
TaKO8Ki
approved these changes
Apr 27, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 27, 2026
…t-ice, r=TaKO8Ki Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder `UnsafeBinder` uses the inner layout, but the debug layout check still looked at the outer type. Check the inner type first so this does not ICE. Tracking issue: rust-lang#130516 Closes: rust-lang#154426
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
…uwer Rollup of 9 pull requests Successful merges: - #155760 (Remove `AttributeLintKind`) - #154510 (Partially stabilize LoongArch target features) - #155137 (Allow trailing `self` in more contexts) - #155433 (Rip out rustc_layout_scalar_valid_range_* attribute support) - #155702 (Change `ItemKind::Trait` to a field variant.) - #154896 (Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder) - #155675 (Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing `ConstParamTy`) - #155874 (Avoid misleading closure return type note) - #155876 (CI: rfl: move job forward to Linux v7.1-rc1)
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
…uwer Rollup of 8 pull requests Successful merges: - #154510 (Partially stabilize LoongArch target features) - #155137 (Allow trailing `self` in more contexts) - #155513 (rustc_public: implement `Pattern` type) - #155702 (Change `ItemKind::Trait` to a field variant.) - #154896 (Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder) - #155675 (Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing `ConstParamTy`) - #155874 (Avoid misleading closure return type note) - #155876 (CI: rfl: move job forward to Linux v7.1-rc1)
rust-timer
added a commit
that referenced
this pull request
Apr 28, 2026
Rollup merge of #154896 - cijiugechu:fix-unsafe-binder-layout-ice, r=TaKO8Ki Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder `UnsafeBinder` uses the inner layout, but the debug layout check still looked at the outer type. Check the inner type first so this does not ICE. Tracking issue: #130516 Closes: #154426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnsafeBinderuses the inner layout, but the debug layout check still looked at the outer type. Check the inner type first so this does not ICE.Tracking issue: #130516
Closes: #154426