Add rlib digest to identify Rust object files by mehdiakiki · Pull Request #154861 · rust-lang/rust

mehdiakiki · 2026-04-06T00:11:25Z

This adds a metadata entry to rlib archives that lists which members are Rust object files instead of relying on the filename heuristic in looks_like_rust_object.file. I also added a fallback to the old behavior for rlibs built by older compilers.

Part of #138243.

rustbot · 2026-04-06T00:11:32Z

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: codegen, compiler
codegen, compiler expanded to 69 candidates
Random selection from 11 candidates

mati865 · 2026-04-06T07:06:57Z

Got too much on my plate already.

@rustbot reroll

mehdiakiki · 2026-04-08T00:52:38Z

Will address the review comments by tomorrow!

rustbot · 2026-04-14T01:14:57Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

rustbot · 2026-04-14T01:19:52Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

mehdiakiki · 2026-05-04T13:10:33Z

Ok will complete the name changes today.

mehdiakiki · 2026-05-05T01:56:25Z

@rustbot ready

petrochenkov · 2026-05-05T04:10:28Z

@bors r+

rust-bors · 2026-05-05T04:10:31Z

📌 Commit 9606b0b has been approved by petrochenkov

It is now in the queue for this repository.

…ochenkov Add rlib digest to identify Rust object files This adds a metadata entry to `rlib` archives that lists which members are Rust object files instead of relying on the filename heuristic in `looks_like_rust_object.file`. I also added a fallback to the old behavior for `rlibs` built by older compilers. Part of rust-lang#138243.

Rollup of 3 pull requests Successful merges: - #154861 (Add rlib digest to identify Rust object files) - #155341 (generic_const_args: allow paths to non type consts) - #156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better)

Add rlib digest to identify Rust object files This adds a metadata entry to `rlib` archives that lists which members are Rust object files instead of relying on the filename heuristic in `looks_like_rust_object.file`. I also added a fallback to the old behavior for `rlibs` built by older compilers. Part of #138243.

rust-log-analyzer · 2026-05-05T12:54:33Z

The job x86_64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test expr_store::tests::body::async_fn_weird_param_patterns ... ok
test expr_store::scope::tests::while_let_adds_binding ... ok
test expr_store::tests::body::array_element_cfg ... ok
test expr_store::tests::body::block::inner_item_smoke ... ok
error: test failed, to rerun pass `-p hir-def --lib`

Caused by:
  process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/hir_def-c439368f2b64a049 '--skip=tests::smoke_test_real_sysroot_cargo' --skip=check_code_formatting -Z unstable-options --format json` (signal: 11, SIGSEGV: invalid memory reference)
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Build completed unsuccessfully in 1:01:16
  local time: Tue May  5 12:54:17 UTC 2026
  network time: Tue, 05 May 2026 12:54:18 GMT
##[error]Process completed with exit code 1.

rust-bors · 2026-05-05T12:55:28Z

💔 Test for ee26d47 failed: CI. Failed job:

auto - x86_64-gnu-llvm-21-1 (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-05-05T12:58:00Z

@bors retry

rust-bors · 2026-05-05T19:35:32Z

☀️ Test successful - CI
Approved by: petrochenkov
Duration: 3h 8m 44s
Pushing 740679e to main...

github-actions · 2026-05-05T19:38:38Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4feb722 (parent) -> 740679e (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 740679e1f5554a3c1695317e084809e3fceb9825 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-various: 1h 29m -> 1h 56m (+31.4%)
dist-x86_64-msvc-alt: 2h 8m -> 2h 42m (+25.9%)
x86_64-msvc-2: 2h 33m -> 2h (-21.6%)
x86_64-gnu-debug: 1h 55m -> 1h 30m (-21.4%)
dist-powerpc64le-linux-gnu: 1h 34m -> 1h 16m (-19.5%)
dist-armhf-linux: 1h 28m -> 1h 11m (-18.8%)
dist-loongarch64-musl: 1h 47m -> 1h 28m (-17.9%)
dist-x86_64-musl: 2h 11m -> 1h 48m (-17.5%)
dist-i686-msvc: 2h 22m -> 1h 59m (-16.3%)
dist-x86_64-netbsd: 1h 22m -> 1h 10m (-14.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-05-05T20:53:46Z

Finished benchmarking commit (740679e): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.3%, 0.6%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.2%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.6%, 0.9%]	2
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Cycles

Results (primary 0.1%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	1.2%	[0.5%, 2.5%]	6
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-0.5%	[-0.6%, -0.4%]	2
All ❌✅ (primary)	0.1%	[-2.1%, 2.3%]	2

Binary size

Results (primary 0.1%, secondary 0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	65
Regressions ❌ (secondary)	0.7%	[0.0%, 4.1%]	84
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.2%]	65

Bootstrap: 495.518s -> 495.494s (-0.00%)
Artifact size: 394.42 MiB -> 394.42 MiB (0.00%)

rustbot assigned mati865 Apr 6, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 6, 2026

This comment has been minimized.

Sign in to view

mehdiakiki force-pushed the fix/rlib-digest branch from 4b32d99 to d966fa8 Compare April 6, 2026 00:39

This comment has been minimized.

Sign in to view

rustbot assigned chenyukang and unassigned mati865 Apr 6, 2026

bjorn3 reviewed Apr 6, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_ssa/src/back/link.rs Outdated

bjorn3 reviewed Apr 6, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_ssa/src/back/rlib_digest.rs Outdated

bjorn3 reviewed Apr 6, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_ssa/src/back/link.rs Outdated

bjorn3 reviewed Apr 6, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_ssa/src/back/rlib_digest.rs Outdated

petrochenkov self-assigned this Apr 6, 2026

petrochenkov reviewed Apr 7, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_ssa/src/back/link.rs Outdated

Comment thread compiler/rustc_codegen_ssa/src/back/link.rs Outdated

Comment thread compiler/rustc_codegen_ssa/src/back/rlib_digest.rs Outdated

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2026

mehdiakiki force-pushed the fix/rlib-digest branch from d966fa8 to 8276413 Compare April 9, 2026 01:45

This comment has been minimized.

Sign in to view

mehdiakiki force-pushed the fix/rlib-digest branch from 8276413 to 18bc7ad Compare April 9, 2026 02:05

bjorn3 reviewed Apr 9, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_ssa/src/back/link.rs Outdated

mehdiakiki force-pushed the fix/rlib-digest branch from 18bc7ad to 9834088 Compare April 14, 2026 01:14

rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Apr 14, 2026

This comment has been minimized.

Sign in to view

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Apr 14, 2026

This comment has been minimized.

Sign in to view

Add rlib digest to identify Rust object files

9606b0b

mehdiakiki force-pushed the fix/rlib-digest branch from d4c808c to 9606b0b Compare May 5, 2026 01:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 5, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2026

jhpratt mentioned this pull request May 5, 2026

Rollup of 3 pull requests #156179

Closed

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 5, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 5, 2026

rust-bors Bot merged commit 740679e into rust-lang:main May 5, 2026
12 checks passed

rustbot added this to the 1.97.0 milestone May 5, 2026

Uh oh!

Conversation

mehdiakiki commented Apr 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

mati865 commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mehdiakiki commented Apr 8, 2026

Uh oh!

This comment has been minimized.

Uh oh!

rustbot commented Apr 14, 2026

Uh oh!

rustbot commented Apr 14, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

mehdiakiki commented May 4, 2026

Uh oh!

mehdiakiki commented May 5, 2026

Uh oh!

petrochenkov commented May 5, 2026

Uh oh!

rust-bors Bot commented May 5, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented May 5, 2026

Uh oh!

rust-bors Bot commented May 5, 2026

Uh oh!

JonathanBrouwer commented May 5, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 5, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 5, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented May 5, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mehdiakiki commented Apr 6, 2026 •

edited by rustbot

Loading

mati865 commented Apr 6, 2026 •

edited

Loading