Rollup of 2 pull requests#154842
Conversation
The `user_arg_index` nomenclature can be applied more broadly, but then the diff becomes annoyingly big, so I chose not to do that.
So that the impact of the commit that fixes the test can be seen clearly.
When there is a lifetime error, the code does its best to find variables that correspond to the lifetimes involved. This commit stops mentioning arguments that are unused in closures, since they are not relevant. See the diff of the blessed test to get a good clue of what that means.
…lubby789,jieyouxu Make sure we run the full suite, even when more specific filters are given Some test suite's filter code took this into account, while others didn't. Imagine this: ``` x test tests/ui/sometest.rs tests/ui ``` This would run only `tests/ui/sometest.rs` since we filtered out `tests/ui` since it matches the name of the test suite. The reason `x test tests/ui` on its own works, is that if compiletest gets no filter paths, only a suite, it runs the entire suite. What I've implemented here is that when you pass the suite path, we effectively ignore specific filters and just run the entire suite since that'll include the more specific paths too. This was the case for a few other suites as well, like rustdocjs, but others actually handle this correctly (like clippy, which my code does edit but for which the behavior doesn't change). Hope this makes sense!
…mann borrowck: Don't mention unused vars in closure outlive errors When there is a closure arg lifetime error, the code does its best to find variables that correspond to the lifetimes involved. This commit stops mentioning arguments that are unused in closures, since they are not relevant. This removes the "red herring" of rust-lang#113121. The `user_arg_index` nomenclature can be applied more broadly, but then the diff becomes annoyingly big, so I chose not to do that. Review each commit individually for a nicer experience.
|
@bors r+ rollup=never p=5 |
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: e73c56abd0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing e73c56a (parent) -> 9602bda (this PR) Test differencesShow 2 test diffsStage 1
Stage 2
Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 9602bda1dd0c1bbf5787e398385bbac81fd532f8 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (9602bda): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 493.268s -> 485.742s (-1.53%) |
Successful merges:
r? @ghost
Create a similar rollup