Skip to content

triagebot: Mention 'subtree' in clippy message#154465

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
clubby789:clippy-msg
Apr 27, 2026
Merged

triagebot: Mention 'subtree' in clippy message#154465
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
clubby789:clippy-msg

Conversation

@clubby789
Copy link
Copy Markdown
Contributor

@clubby789 clubby789 commented Mar 27, 2026

#154396 (comment)

This makes it more obvious a subtree is being changed, similarly to Miri and rustc-dev-guide

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 27, 2026

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 27, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
  • Random selection from Mark-Simulacrum, jieyouxu

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Mar 27, 2026

Could we mention 'subtree' for all subtrees please.

Git subtrees that have ever existed:

compiler/rustc_codegen_cranelift
compiler/rustc_codegen_gcc
compiler/rustc_smir
library/portable-simd
src/tools/clippy
src/tools/miri
src/tools/rust-analyzer
src/tools/rustfmt

Josh subtrees:

library/compiler-builtins
library/stdarch
src/tools/rust-analyzer
src/tools/miri
src/doc/rustc-dev-guide

jieyouxu
jieyouxu approved these changes Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This itself is nice, the suggestion for other subtrees seems reasonable too, but up to you, not going to block on that.

r=me with or without other subtrees

@rustbot author

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 28, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 24, 2026

⚠️ Warning ⚠️

@clubby789
Copy link
Copy Markdown
Contributor Author

clubby789 commented Apr 24, 2026

Added a mention of 'subtree' to all subtrees that don't have an existing more detail message
@bors r=jieyouxu

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

📌 Commit fe11b0d has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 24, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented Apr 24, 2026 •
edited
Loading

Unfortunately u got tidy'd

tidy [triagebot]: triagebot.toml [mentions.*] contains 'compiler/rustc_smir' which doesn't match any file or directory in the repository
tidy [triagebot]: FAIL

@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented Apr 24, 2026

@bors r-

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

This pull request was unapproved.

View changes since this unapproval

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Apr 24, 2026

Git subtrees that have ever existed:

compiler/rustc_codegen_cranelift
compiler/rustc_codegen_gcc
compiler/rustc_smir
library/portable-simd
src/tools/clippy
src/tools/miri
src/tools/rust-analyzer
src/tools/rustfmt

I'm not sure of the status of all of these, compiler/rustc_smir for instance was renamed and may no longer be a subtree.

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Apr 24, 2026

@oli-obk Is compiler/rustc_public meant to be maintained as a subtree? It appears to have diverged from the copy in project-stable-mir, and it doesn’t show up when searching for subtree markers with:

git log --grep="git-subtree-dir: " --pretty=format:%B | grep "git-subtree-dir: "

@oli-obk
Copy link
Copy Markdown
Contributor

oli-obk commented Apr 24, 2026

@celinval correct me if I'm wrong, but i think it's only syncs away from rust-lang/rust never into it right?

@clubby789
Copy link
Copy Markdown
Contributor Author

clubby789 commented Apr 27, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 27, 2026
@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented Apr 27, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 27, 2026

📌 Commit 36bd34e has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 27, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Apr 27, 2026
@bors
Auto merge of #155878 - JonathanBrouwer:rollup-zIfAviV, r=JonathanBro…
345a975 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154465 (triagebot: Mention 'subtree' in clippy message)
 - #155355 (Fix pathological performance in trait solver cycles with errors)
 - #155716 (arm64e: set ptrauth ABI subtype on lib.rmeta Mach-O objects)
 - #155864 (Fix panic for doc attributes on where predicates)
 - #155865 (add test for accidentally fixed `binius_field` issue)
 - #155866 (Render `ConstContext` for diagnostics once)
@rust-bors rust-bors Bot merged commit 67e7a1e into rust-lang:main Apr 27, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 27, 2026
rust-timer added a commit that referenced this pull request Apr 27, 2026
@rust-timer
Unrolled build for #154465
0da3f15 
Rollup merge of #154465 - clubby789:clippy-msg, r=jieyouxu

triagebot: Mention 'subtree' in clippy message

#154396 (comment)

This makes it more obvious a subtree is being changed, similarly to Miri and `rustc-dev-guide`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

7 participants

@clubby789 @rustbot @xtqqczze @rust-log-analyzer @jieyouxu @oli-obk @jamie-osec