Skip to content

Exposing Float Masks#154372

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Apersoma:float_masks
Apr 25, 2026
Merged

Exposing Float Masks#154372
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Apersoma:float_masks

Conversation

@Apersoma
Copy link
Copy Markdown
Contributor

@Apersoma Apersoma commented Mar 25, 2026 •
edited by rustbot
Loading

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 25, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev
Copy link
Copy Markdown
Contributor

folkertdev commented Apr 18, 2026

This seems useful, do ask if you need help here

@Apersoma Apersoma marked this pull request as ready for review April 22, 2026 22:01
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 22, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 22, 2026

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 22, 2026

⚠️ Warning ⚠️

@Apersoma
Copy link
Copy Markdown
Contributor Author

Apersoma commented Apr 22, 2026

@folkertdev would you be interested in reviewing this?

folkertdev
folkertdev requested changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@folkertdev folkertdev left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I did a first pass. Also, can you rebase this? We're OK with people just force-pushing, we have some custom tooling that keeps reviews manageable.

r? folkertdev

View changes since this review

Comment thread compiler/rustc_feature/src/unstable.rs Outdated
Comment thread library/core/src/num/f128.rs Outdated
Comment thread library/core/src/num/f16.rs Outdated
Comment thread library/core/src/num/f16.rs Outdated
Comment thread library/core/src/num/f16.rs Outdated
@rustbot rustbot assigned folkertdev and unassigned scottmcm Apr 22, 2026
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 22, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Apersoma
Copy link
Copy Markdown
Contributor Author

Apersoma commented Apr 22, 2026 •
edited
Loading

i'll squash it at the end

@Apersoma
Copy link
Copy Markdown
Contributor Author

Apersoma commented Apr 23, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 23, 2026
tgross35
tgross35 reviewed Apr 23, 2026
View reviewed changes
Comment thread compiler/rustc_span/src/symbol.rs Outdated
Comment thread tests/ui/feature-gates/feature-gate-float-masks.rs Outdated
Comment thread library/core/src/num/f16.rs Outdated
Comment thread library/core/src/num/f16.rs
Comment thread library/core/src/num/f16.rs
Comment thread library/core/src/num/f16.rs Outdated
Comment thread library/core/src/num/f16.rs
Comment thread library/core/src/num/f16.rs Outdated
@tgross35
Copy link
Copy Markdown
Contributor

tgross35 commented Apr 23, 2026

When you do squash, please make sure the commit message says what the change does similar to the PR message. Currently it's "Added the symbol" :)

Unfortunately we have no squash+merge on this repo so the commits are what shows up in the history and blame.

@Apersoma
Copy link
Copy Markdown
Contributor Author

Apersoma commented Apr 24, 2026

@rustbot ready

tgross35
tgross35 approved these changes Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 24, 2026

📌 Commit d5b941d has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 24, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2026
@Apersoma
Copy link
Copy Markdown
Contributor Author

Apersoma commented Apr 24, 2026

@tgross35
how long should I wait on a stability pr and is the FCP before or after that pr?

@Apersoma Apersoma mentioned this pull request Apr 24, 2026
Open
4 tasks
@tgross35
Copy link
Copy Markdown
Contributor

tgross35 commented Apr 25, 2026

@tgross35 how long should I wait on a stability pr

These are straightforward and likely pretty unobjectionable, so waiting a few releases would probably be reasonable.

and is the FCP before or after that pr?

I always prefer a PR first so we can see what changes. It can be nominated, then FCP gets started after the meeting.

jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 25, 2026
@jhpratt
Rollup merge of rust-lang#154372 - Apersoma:float_masks, r=tgross35
e9d170c 
Exposing Float Masks

Tracking issue: rust-lang#154064
ACP: rust-lang/libs-team#753
This was referenced Apr 25, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
@bors
Auto merge of #155766 - jhpratt:rollup-EcXAaqS, r=jhpratt
7e0430f 
Rollup of 7 pull requests

Successful merges:

 - #155643 (Improve suggestion for $-prefixed fragment specifiers)
 - #154197 (Avoid redundant clone suggestions in borrowck diagnostics)
 - #154372 (Exposing Float Masks)
 - #155680 (Handle index projections in call destinations in DSE)
 - #155732 (bootstrap: Don't clone submodules unconditionally in dry-run)
 - #155737 (Account for `GetSyntheticValue` failures)
 - #155738 (Pass fields to `is_tuple_fields` instead of `SBValue` object)
@rust-bors rust-bors Bot merged commit b3ccc96 into rust-lang:main Apr 25, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 25, 2026
rust-timer added a commit that referenced this pull request Apr 25, 2026
@rust-timer
Unrolled build for #154372
863518e 
Rollup merge of #154372 - Apersoma:float_masks, r=tgross35

Exposing Float Masks

Tracking issue: #154064
ACP: rust-lang/libs-team#753
@Apersoma Apersoma deleted the float_masks branch April 25, 2026 21:42
@Apersoma Apersoma mentioned this pull request Apr 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdev folkertdev folkertdev requested changes

@tgross35 tgross35 tgross35 approved these changes

Assignees

@folkertdev folkertdev

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Apersoma @rust-log-analyzer @folkertdev @rustbot @tgross35 @scottmcm