Skip to content

document some functions on AttributeExt#154299

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
jdonszelmann:document-attribute-ext
Mar 24, 2026
Merged

document some functions on AttributeExt#154299
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
jdonszelmann:document-attribute-ext

Conversation

@jdonszelmann
Copy link
Copy Markdown
Contributor

@jdonszelmann jdonszelmann commented Mar 24, 2026

r? @jyn514

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 24, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 24, 2026

Failed to set assignee to jyn514: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@jdonszelmann
Copy link
Copy Markdown
Contributor Author

jdonszelmann commented Mar 24, 2026 •
edited
Loading

r? jonathanbrouwer

(@jyn514 was having fun with attributes and we noticed these could use some pointers)

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 24, 2026

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

JonathanBrouwer
JonathanBrouwer approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Mar 24, 2026

📌 Commit c87cd68 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 24, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Mar 24, 2026
@bors
Auto merge of #154300 - JonathanBrouwer:rollup-MkFxTPv, r=JonathanBro…
0312931 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #153434 (Use a safe `BucketIndex` abstraction in `VecCache`)
 - #154133 (Defer codegen for the VaList Drop impl to actual uses)
 - #154297 (fix/extend some mir-opt comments)
 - #154299 (document some functions on AttributeExt)
@rust-bors rust-bors Bot merged commit 6f67067 into rust-lang:main Mar 24, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

+1 more reviewer

@jyn514 jyn514 jyn514 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jdonszelmann @rustbot @JonathanBrouwer @jyn514