Skip to content

Defer codegen for the VaList Drop impl to actual uses#154133

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
bjorn3:va_list_drop_defer_codegen
Mar 24, 2026
Merged

Defer codegen for the VaList Drop impl to actual uses#154133
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
bjorn3:va_list_drop_defer_codegen

Conversation

@bjorn3
Copy link
Copy Markdown
Member

@bjorn3 bjorn3 commented Mar 20, 2026

This allows compiling libcore with codegen backends that don't actually implement VaList like cg_clif.

@bjorn3
Defer codegen for the VaList Drop impl to actual uses
0b69ff5 
This allows compiling libcore with codegen backends that don't actually
implement VaList like cg_clif.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 20, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 20, 2026

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 14 candidates

@bjorn3 bjorn3 mentioned this pull request Mar 20, 2026
Open
nnethercote
nnethercote reviewed Mar 21, 2026
View reviewed changes
Comment thread library/core/src/ffi/va_list.rs Outdated
nnethercote
nnethercote approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nnethercote nnethercote left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the typos fixed.

View changes since this review

Comment thread library/core/src/ffi/va_list.rs Outdated
@nnethercote nnethercote added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2026
@bjorn3 bjorn3 force-pushed the va_list_drop_defer_codegen branch from 82cab3a to 366cf88 Compare March 24, 2026 09:02
@bjorn3
Copy link
Copy Markdown
Member Author

bjorn3 commented Mar 24, 2026

@bors r=nnethercote

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Mar 24, 2026

📌 Commit 366cf88 has been approved by nnethercote

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 24, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 24, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Mar 24, 2026
@bors
Auto merge of #154300 - JonathanBrouwer:rollup-MkFxTPv, r=JonathanBro…
0312931 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #153434 (Use a safe `BucketIndex` abstraction in `VecCache`)
 - #154133 (Defer codegen for the VaList Drop impl to actual uses)
 - #154297 (fix/extend some mir-opt comments)
 - #154299 (document some functions on AttributeExt)
@rust-bors rust-bors Bot merged commit fad2a35 into rust-lang:main Mar 24, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 24, 2026
@bjorn3 bjorn3 deleted the va_list_drop_defer_codegen branch March 24, 2026 15:14
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Mar 25, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154133 - bjorn3:va_list_drop_defer_codegen,…
f51c96a 
… r=nnethercote

Defer codegen for the VaList Drop impl to actual uses

This allows compiling libcore with codegen backends that don't actually implement VaList like cg_clif.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nnethercote nnethercote nnethercote approved these changes

Assignees

@nnethercote nnethercote

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bjorn3 @rustbot @nnethercote