fix spurious test failure in metadata_access_times#153871
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 12, 2026
Merged
fix spurious test failure in metadata_access_times#153871rust-bors[bot] merged 1 commit intorust-lang:mainfrom
metadata_access_times#153871rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Mark-Simulacrum
added
S-waiting-on-author
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Member
|
@bors squash |
Contributor
|
🚧 Squashing... this can take a few minutes. |
Contributor
|
❗ Failed to push the squashed commit to |
Member
|
@bors squash |
Contributor
|
🚧 Squashing... this can take a few minutes. |
* remove time assertion on SystemTime * skip test only if when a time change occurs
Contributor
|
❗ Failed to push the squashed commit to |
Mark-Simulacrum
force-pushed
the
issue-148408
branch
from
0f8c012 to
9371fea
Compare
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 11, 2026
…-Simulacrum fix spurious test failure in `metadata_access_times` Fixes rust-lang#148408 The metadata_access_times test checks if the creation of a file occurs before another file, this check happens only on Linux. While on Win and Macos we check only that the created metadata is available. Given that the SystemTime is non monotonic as Instant this test could result in failures when the system clock changes.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 11, 2026
…-Simulacrum fix spurious test failure in `metadata_access_times` Fixes rust-lang#148408 The metadata_access_times test checks if the creation of a file occurs before another file, this check happens only on Linux. While on Win and Macos we check only that the created metadata is available. Given that the SystemTime is non monotonic as Instant this test could result in failures when the system clock changes.
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 12, 2026
Rollup of 7 pull requests Successful merges: - #155084 (Initial functions to start on transmute v2) - #155126 (add `cfg(target_object_format = "...")`) - #155165 (Portable SIMD subtree update) - #153871 (fix spurious test failure in `metadata_access_times`) - #155150 (replace <name> @ ty::AliasTy matches with just using args: <name>_args) - #155159 (Fix min-specialization ICE from ignored region resolution failure) - #155167 (Reduce size of `ImportData`)
rust-timer
added a commit
that referenced
this pull request
Apr 12, 2026
Rollup merge of #153871 - mattiapitossi:issue-148408, r=Mark-Simulacrum fix spurious test failure in `metadata_access_times` Fixes #148408 The metadata_access_times test checks if the creation of a file occurs before another file, this check happens only on Linux. While on Win and Macos we check only that the created metadata is available. Given that the SystemTime is non monotonic as Instant this test could result in failures when the system clock changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148408
The metadata_access_times test checks if the creation of a file occurs before another file, this check happens only on Linux. While on Win and Macos we check only that the created metadata is available. Given that the SystemTime is non monotonic as Instant this test could result in failures when the system clock changes.