Skip to content

Enable link relaxation feature for LoongArch Linux targets#153427

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
heiher:loong64-linux-relax
Mar 9, 2026
Merged

Enable link relaxation feature for LoongArch Linux targets#153427
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
heiher:loong64-linux-relax

Conversation

@heiher

@heiher heiher commented Mar 5, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

This patch series enables the link relaxation feature for LoongArch Linux targets. Link relaxation is a link-time optimization that helps improve the quality and efficiency of the final binary. To support this, the corss-toolchain has also been bumped to handle more types of link relaxation.

@rustbot

rustbot commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra-ci
  • infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
  • Random selection from Mark-Simulacrum, jdno, jieyouxu, marcoieni

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 5, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu closed this Mar 5, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2026
@jieyouxu jieyouxu reopened this Mar 5, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2026
@jieyouxu jieyouxu added the O-loongarch Target: LoongArch (LA32R, LA32S, LA64) label Mar 5, 2026
jieyouxu
jieyouxu reviewed Mar 5, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change themselves look fine, some doc / target baseline questions

View changes since this review

Comment thread src/ci/docker/scripts/crosstool-ng.sh
set -ex

CT_NG=1.27.0
CT_NG=1.28.0

@jieyouxu jieyouxu Mar 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: https://github.com/crosstool-ng/crosstool-ng/releases/tag/crosstool-ng-1.28.0

Comment thread src/ci/docker/host-x86_64/dist-loongarch64-linux/loongarch64-unknown-linux-gnu.defconfig
Comment thread compiler/rustc_target/src/spec/targets/loongarch64_unknown_linux_gnu.rs
@jieyouxu

jieyouxu commented Mar 5, 2026

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2026
@rustbot

rustbot commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@heiher
heiher force-pushed the loong64-linux-relax branch from afb3946 to c2c26c0 Compare March 6, 2026 03:51
@rustbot

rustbot commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@heiher

heiher commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2026
jieyouxu
jieyouxu approved these changes Mar 6, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@bors r+ rollup=never

View changes since this review

@rust-bors

rust-bors Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c2c26c0 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2026
@jieyouxu jieyouxu added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 6, 2026
@rustbot rustbot mentioned this pull request Mar 6, 2026
Closed
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 596e918 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@heiher

heiher commented Mar 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Oops, these patches are included in crosstool-ng 1.28.0:

@heiher
heiher force-pushed the loong64-linux-relax branch from c2c26c0 to cd9cb3f Compare March 7, 2026 12:55
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2026
@heiher

heiher commented Mar 7, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 7, 2026
@jieyouxu

jieyouxu commented Mar 8, 2026

Copy link
Copy Markdown
Member

@bors try jobs=dist-riscv64-linux

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Mar 8, 2026
@bors
Auto merge of #153427 - heiher:loong64-linux-relax, r=<try>
2b97378 
Enable link relaxation feature for LoongArch Linux targets


try-job: dist-riscv64-linux
@rust-bors

rust-bors Bot commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 2b97378 (2b97378b485020ac21882dcb46436de323f3c7ba, parent: c3d014032f39a252387ca7c4fe4039c1b7c01eb4)

@jieyouxu

jieyouxu commented Mar 9, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit cd9cb3f has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2026
@rust-bors

rust-bors Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jieyouxu
Duration: 4h 6m 5s
Pushing 655a7d2 to main...

@rust-bors
rust-bors Bot merged commit 655a7d2 into rust-lang:main Mar 9, 2026
13 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 9, 2026
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 98e7077 (parent) -> 655a7d2 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 655a7d20fefe23757ca9ecbbea01e4fe80208aaf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-powerpc64le-linux-gnu: 1h 33m -> 3h 9m (+103.5%)
  2. dist-powerpc64le-linux-musl: 1h 33m -> 3h 6m (+100.5%)
  3. dist-powerpc64-linux-musl: 1h 37m -> 3h 8m (+93.8%)
  4. dist-loongarch64-musl: 1h 50m -> 3h 22m (+83.7%)
  5. dist-loongarch64-linux: 1h 51m -> 3h 20m (+79.9%)
  6. aarch64-apple: 3h 7m -> 3h 59m (+27.7%)
  7. x86_64-rust-for-linux: 42m 34s -> 53m 47s (+26.4%)
  8. x86_64-gnu-miri: 1h 17m -> 1h 36m (+23.5%)
  9. pr-check-1: 27m 51s -> 33m 7s (+18.9%)
  10. aarch64-gnu-llvm-20-1: 54m 6s -> 1h 2m (+15.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@heiher
heiher deleted the loong64-linux-relax branch March 9, 2026 12:44
@rust-timer

rust-timer commented Mar 9, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (655a7d2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.865s -> 479.555s (-0.06%)
Artifact size: 395.05 MiB -> 395.03 MiB (-0.01%)

@BoxyUwU BoxyUwU mentioned this pull request May 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-loongarch Target: LoongArch (LA32R, LA32S, LA64) relnotes Marks issues that should be documented in the release notes of the next release. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

5 participants

@heiher @rustbot @rust-log-analyzer @jieyouxu @rust-timer