Revert "Stabilize str_as_str"#152963
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Feb 23, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
revert-str-as-str
branch
from
63d80dd to
9f0a410
Compare
Member
|
Can a regression test be added (i.e. #152961 (comment)) to catch future re-regressions? |
Contributor
Author
|
Not sure what folder in tests is the best place, I'm picking |
JonathanBrouwer
force-pushed
the
revert-str-as-str
branch
from
58ecac9 to
51d7272
Compare
Member
|
Yeah I'm not sure, since this really is more of a libs test. Maybe the libs reviewer will have a better idea. Still, having a test to catch future re-regressions is better than not having any. |
This was referenced Feb 22, 2026
Contributor
|
LGTM, |
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Member
|
Regarding location, I don't think it particularly matters, as this is hopefully short lived :) |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 22, 2026
… r=jhpratt Revert "Stabilize `str_as_str`" Reverts rust-lang#151603, clean revert. Fixes rust-lang#152961
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Feb 22, 2026
… r=jhpratt Revert "Stabilize `str_as_str`" Reverts rust-lang#151603, clean revert. Fixes rust-lang#152961
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
Rollup of 9 pull requests Successful merges: - #152229 (Remove deterministic picking from query cycle handling) - #152970 (extend unpin noalias tests to cover mutable references) - #149783 (stabilize `cfg_select!`) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152366 (Add try_shrink_to and try_shrink_to_fit to Vec) - #152640 (Add direct link to rustc-dev-guide in README) - #152963 (Revert "Stabilize `str_as_str`") - #152984 (Remove redundant call to `check_codegen_attributes_extra` in Inliner) - #152987 (Use `HashStable` derive in more places)
niran
added a commit
to base/base
that referenced
this pull request
Feb 23, 2026
nightly-2026-02-22+ includes the str::as_str() stabilization (rust-lang/rust#151603) which shadows shellexpand 3.1.1's WstrExt::as_str() trait method, causing a compile error. Pin to nightly-2026-02-21 and invoke cargo-udeps directly since `just check-udeps` hardcodes `cargo +nightly`. Revert once rust-lang/rust#152963 lands in nightly.
3 tasks
rust-timer
added a commit
that referenced
this pull request
Feb 23, 2026
github-merge-queue bot
pushed a commit
to base/base
that referenced
this pull request
Feb 23, 2026
nightly-2026-02-22+ includes the str::as_str() stabilization (rust-lang/rust#151603) which shadows shellexpand 3.1.1's WstrExt::as_str() trait method, causing a compile error. Pin to nightly-2026-02-21 and invoke cargo-udeps directly since `just check-udeps` hardcodes `cargo +nightly`. Revert once rust-lang/rust#152963 lands in nightly.
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Feb 24, 2026
Rollup of 9 pull requests Successful merges: - rust-lang/rust#152229 (Remove deterministic picking from query cycle handling) - rust-lang/rust#152970 (extend unpin noalias tests to cover mutable references) - rust-lang/rust#149783 (stabilize `cfg_select!`) - rust-lang/rust#151744 (fix refining_impl_trait suggestion with return_type_notation) - rust-lang/rust#152366 (Add try_shrink_to and try_shrink_to_fit to Vec) - rust-lang/rust#152640 (Add direct link to rustc-dev-guide in README) - rust-lang/rust#152963 (Revert "Stabilize `str_as_str`") - rust-lang/rust#152984 (Remove redundant call to `check_codegen_attributes_extra` in Inliner) - rust-lang/rust#152987 (Use `HashStable` derive in more places)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #151603, clean revert.
Fixes #152961