Skip to content

Comments

Partially revert "resolve: Update NameBindingData::vis in place"#152498

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
petrochenkov:revoverglob
Feb 12, 2026
Merged

Partially revert "resolve: Update NameBindingData::vis in place"#152498
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
petrochenkov:revoverglob

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Feb 11, 2026

Partial revert of 227e7bd.
This is a minimal fix for backporting to beta, I'll submit proper fixes later.

Fixes #152004
Fixes #151124
Fixes #152347

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 11, 2026
@petrochenkov petrochenkov marked this pull request as ready for review February 11, 2026 19:34
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 11, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 67 candidates
  • Random selection from 15 candidates

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 12, 2026

📌 Commit 324267c has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 12, 2026
Partially revert "resolve: Update `NameBindingData::vis` in place"

Partial revert of rust-lang@227e7bd.
This is a minimal fix for backporting to beta, I'll submit proper fixes later.

Fixes rust-lang#152004
Fixes rust-lang#151124
Fixes rust-lang#152347
rust-bors bot pushed a commit that referenced this pull request Feb 12, 2026
Rollup of 17 pull requests

Successful merges:

 - #142415 (Add note when inherent impl for a alias type defined outside of the crate)
 - #142680 (Fix passing/returning structs with the 64-bit SPARC ABI)
 - #150768 (Don't compute FnAbi for LLVM intrinsics in backends)
 - #151152 (Add FCW for derive helper attributes that will conflict with built-in attributes)
 - #151814 (layout: handle rigid aliases without params)
 - #151863 (Borrowck: simplify diagnostics for placeholders)
 - #152159 (Add note for `?Sized` params in int-ptr casts diag)
 - #152434 (Clarify names of `QueryVTable` functions for "executing" a query)
 - #152478 (Remove tm_factory field from CodegenContext)
 - #152498 (Partially revert "resolve: Update `NameBindingData::vis` in place")
 - #152316 (fix: add continue)
 - #152394 (Correctly check if a macro call is actually a macro call in rustdoc highlighter)
 - #152425 (Port #![test_runner] to the attribute parser)
 - #152481 (Use cg_ssa's produce_final_output_artifacts in cg_clif)
 - #152485 (fix issue#152482)
 - #152495 (Clean up some subdiagnostics)
 - #152502 (Implement `BinaryHeap::from_raw_vec`)
@rust-bors rust-bors bot merged commit 8193067 into rust-lang:main Feb 12, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 12, 2026
rust-timer added a commit that referenced this pull request Feb 12, 2026
Rollup merge of #152498 - petrochenkov:revoverglob, r=jieyouxu

Partially revert "resolve: Update `NameBindingData::vis` in place"

Partial revert of 227e7bd.
This is a minimal fix for backporting to beta, I'll submit proper fixes later.

Fixes #152004
Fixes #151124
Fixes #152347
@apiraino
Copy link
Contributor

Beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 12, 2026
@cuviper cuviper modified the milestones: 1.95.0, 1.94.0 Feb 12, 2026
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 12, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 12, 2026
[beta] backports, plus stable versions in stdarch

- Replace `stdarch` version placeholders with 1.94
- Parse ident with allowing recovery when trying to diagnose #151249
- Revert enabling `outline-atomics` on various platforms #151896
- Revert doc attribute parsing errors to future warnings #151952
- Remove the 4 failing tests from rustdoc-gui #152194
- Remove rustdoc GUI flaky test #152116
- Align `ArrayWindows` trait impls with `Windows` #151613
- Fix suppression of `unused_assignment` in binding of `unused_variable` #151556
- layout: handle rigid aliases without params #151814
- Fix missing unused_variables lint when using a match guard #151990
- Partially revert "resolve: Update `NameBindingData::vis` in place" #152498
- [BETA]: parse array lengths without stripping const blocks #152237

r? cuviper
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Feb 16, 2026
Rollup of 17 pull requests

Successful merges:

 - rust-lang/rust#142415 (Add note when inherent impl for a alias type defined outside of the crate)
 - rust-lang/rust#142680 (Fix passing/returning structs with the 64-bit SPARC ABI)
 - rust-lang/rust#150768 (Don't compute FnAbi for LLVM intrinsics in backends)
 - rust-lang/rust#151152 (Add FCW for derive helper attributes that will conflict with built-in attributes)
 - rust-lang/rust#151814 (layout: handle rigid aliases without params)
 - rust-lang/rust#151863 (Borrowck: simplify diagnostics for placeholders)
 - rust-lang/rust#152159 (Add note for `?Sized` params in int-ptr casts diag)
 - rust-lang/rust#152434 (Clarify names of `QueryVTable` functions for "executing" a query)
 - rust-lang/rust#152478 (Remove tm_factory field from CodegenContext)
 - rust-lang/rust#152498 (Partially revert "resolve: Update `NameBindingData::vis` in place")
 - rust-lang/rust#152316 (fix: add continue)
 - rust-lang/rust#152394 (Correctly check if a macro call is actually a macro call in rustdoc highlighter)
 - rust-lang/rust#152425 (Port #![test_runner] to the attribute parser)
 - rust-lang/rust#152481 (Use cg_ssa's produce_final_output_artifacts in cg_clif)
 - rust-lang/rust#152485 (fix issue#152482)
 - rust-lang/rust#152495 (Clean up some subdiagnostics)
 - rust-lang/rust#152502 (Implement `BinaryHeap::from_raw_vec`)
@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2026

stable backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbot label +stable-accepted

@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2026

Error: Label stable-accepted can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2026

stable backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbot rustbot added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Feb 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2026

stable backport declined as per compiler team on Zulip.

@rustbot rustbot removed the stable-accepted Accepted for backporting to the compiler in the stable channel. label Feb 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2026

beta backport declined as per compiler team on Zulip.

@rustbot rustbot removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2026

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

5 participants