Skip to content

Derives Copy for ffi::FromBytesUntilNulError#152367

Open
Conaclos wants to merge 1 commit intorust-lang:mainfrom
Conaclos:conaclos/FromBytesUntilNulError-impl-Copy
Open

Derives Copy for ffi::FromBytesUntilNulError#152367
Conaclos wants to merge 1 commit intorust-lang:mainfrom
Conaclos:conaclos/FromBytesUntilNulError-impl-Copy

Conversation

@Conaclos
Copy link
Copy Markdown

@Conaclos Conaclos commented Feb 8, 2026

ffi::FromBytesWithNulError derives Copy since Rust 1.93 while ffi::FromBytesUntilNulError doesn't.
This Pr fixes that by deriving Copy for ffi::FromBytesUntilNulError.

I encountered this issue while I was working in a const context.

Note: I couldn't find any documentation about what kind of PR is allowed. As this one is very small, I guess it is ok to submit it directly without opening an issue first?

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 8, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Feb 8, 2026

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, scottmcm

@scottmcm
Copy link
Copy Markdown
Member

Since this is a new stable type, it amounts to new stable surface area, so it needs libs-api to weigh in on it and FCP it
r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 18, 2026
@rustbot rustbot assigned BurntSushi and unassigned scottmcm Apr 18, 2026
@scottmcm scottmcm added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Apr 18, 2026
@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Apr 21, 2026

@rfcbot merge libs-api

@rust-rfcbot
Copy link
Copy Markdown
Collaborator

rust-rfcbot commented Apr 21, 2026

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 21, 2026
@Amanieu Amanieu removed I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels Apr 21, 2026
@rust-rfcbot rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Apr 28, 2026
@rust-rfcbot
Copy link
Copy Markdown
Collaborator

🔔 This is now entering its final comment period, as per the review above. 🔔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants