Drop remaining ZSTs if array mapping fails#152220
Open
eggyal wants to merge 2 commits intorust-lang:mainfrom
Open
Drop remaining ZSTs if array mapping fails#152220eggyal wants to merge 2 commits intorust-lang:mainfrom
eggyal wants to merge 2 commits intorust-lang:mainfrom
Conversation
Dropping the `Drain` used by the `array::[try_]map` functions should drop any pending elements, whether they are ZST or not.
rustbot
added
S-waiting-on-review
eggyal
commented
Feb 6, 2026
This was referenced Feb 6, 2026
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 27, 2026
core: drop unmapped ZSTs in array `map` Fixes rust-lang#152211. Alternative to rust-lang#152220 and rust-lang#152248. This makes the `Drain` type use the same ZST-handling strategy as `slice::IterMut`, which stores the remaining length instead of a one-past-the-end pointer when the type is a ZST. I've also removed the const-generic `N` parameter from `Drain` to avoid unnecessary monomorphizations.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 27, 2026
core: drop unmapped ZSTs in array `map` Fixes rust-lang#152211. Alternative to rust-lang#152220 and rust-lang#152248. This makes the `Drain` type use the same ZST-handling strategy as `slice::IterMut`, which stores the remaining length instead of a one-past-the-end pointer when the type is a ZST. I've also removed the const-generic `N` parameter from `Drain` to avoid unnecessary monomorphizations.
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
core: drop unmapped ZSTs in array `map` Fixes #152211. Alternative to #152220 and #152248. This makes the `Drain` type use the same ZST-handling strategy as `slice::IterMut`, which stores the remaining length instead of a one-past-the-end pointer when the type is a ZST. I've also removed the const-generic `N` parameter from `Drain` to avoid unnecessary monomorphizations.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 1, 2026
core: drop unmapped ZSTs in array `map` Fixes rust-lang#152211. Alternative to rust-lang#152220 and rust-lang#152248. This makes the `Drain` type use the same ZST-handling strategy as `slice::IterMut`, which stores the remaining length instead of a one-past-the-end pointer when the type is a ZST. I've also removed the const-generic `N` parameter from `Drain` to avoid unnecessary monomorphizations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping the
Drainused by thearray::[try_]mapfunctions should drop any pending elements, whether they are ZST or not.Fixes #152211
r? libs