Skip to content

Comments

Stabilize str_as_str#151603

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
GrigorenkoPV:stabilize/str_as_str
Feb 21, 2026
Merged

Stabilize str_as_str#151603
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
GrigorenkoPV:stabilize/str_as_str

Conversation

@GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Jan 24, 2026 •
edited by rustbot
Loading

Closes #130366

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 24, 2026
@GrigorenkoPV GrigorenkoPV mentioned this pull request Jan 24, 2026
Open
9 tasks
@GrigorenkoPV GrigorenkoPV marked this pull request as ready for review February 4, 2026 09:41
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 4, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jhpratt
Copy link
Member

jhpratt commented Feb 5, 2026

PR LGTM; just needs FCP.

@rustbot label +needs-fcp

@rustbot rustbot added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Feb 5, 2026
@jhpratt jhpratt added S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2026
@the8472
Copy link
Member

the8472 commented Feb 10, 2026

@rfcbot merge libs-api

@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Feb 10, 2026 •
edited by BurntSushi
Loading

Team member @the8472 has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 10, 2026
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Feb 10, 2026

🔔 This is now entering its final comment period, as per the review above. 🔔

@rust-rfcbot rust-rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Feb 20, 2026
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Feb 20, 2026

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

@rustbot rustbot mentioned this pull request Feb 20, 2026
Open
@jhpratt
Copy link
Member

jhpratt commented Feb 20, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-t-libs-api.

@jhpratt jhpratt added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api labels Feb 20, 2026
@jhpratt
Copy link
Member

jhpratt commented Feb 20, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

📌 Commit 0639855 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2026
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 21, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 21, 2026
@matthiaskrgr
Rollup merge of rust-lang#151603 - GrigorenkoPV:stabilize/str_as_str,…
182856d 
… r=jhpratt

Stabilize `str_as_str`

- Tracking issue: rust-lang#130366
- Needs FCP
- `ByteStr` methods remain gated behind `bstr` feature gate (rust-lang#134915)

Closes rust-lang#130366
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 21, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 21, 2026
@bors
Auto merge of #152934 - matthiaskrgr:rollup-lcy7ROk, r=matthiaskrgr
82a8cf2 
Rollup of 6 pull requests

Successful merges:

 - #152929 (Tighten the `!range` bounds on alignments in vtables)
 - #151603 (Stabilize `str_as_str`)
 - #152878 (Remove two more flaky assertions from `oneshot` tests)
 - #152915 (Error on attempt to construct scalable vector type)
 - #152925 (Improve runtest revision redundant cfg check)
 - #152928 (Update wasm-component-ld)
rust-bors bot pushed a commit that referenced this pull request Feb 21, 2026
@bors
Auto merge of #152934 - matthiaskrgr:rollup-lcy7ROk, r=matthiaskrgr
5fb2ff8 
Rollup of 6 pull requests

Successful merges:

 - #152929 (Tighten the `!range` bounds on alignments in vtables)
 - #151603 (Stabilize `str_as_str`)
 - #152878 (Remove two more flaky assertions from `oneshot` tests)
 - #152915 (Error on attempt to construct scalable vector type)
 - #152925 (Improve runtest revision redundant cfg check)
 - #152928 (Update wasm-component-ld)
@rust-bors rust-bors bot merged commit a919df8 into rust-lang:main Feb 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 21, 2026
rust-timer added a commit that referenced this pull request Feb 21, 2026
@rust-timer
Unrolled build for #151603
8172a9f 
Rollup merge of #151603 - GrigorenkoPV:stabilize/str_as_str, r=jhpratt

Stabilize `str_as_str`

- Tracking issue: #130366
- Needs FCP
- `ByteStr` methods remain gated behind `bstr` feature gate (#134915)

Closes #130366
@GrigorenkoPV GrigorenkoPV deleted the stabilize/str_as_str branch February 21, 2026 23:50
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 22, 2026
Closed
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 22, 2026

This PR caused a regression: #152961

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 22, 2026
@JonathanBrouwer
Revert "Rollup merge of rust-lang#151603 - GrigorenkoPV:stabilize/str…
63d80dd 
…_as_str, r=jhpratt"

This reverts commit a919df8, reversing
changes made to 7339fc5.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 22, 2026
Merged
@GrigorenkoPV GrigorenkoPV mentioned this pull request Feb 22, 2026
Open
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152963 - JonathanBrouwer:revert-str-as-str,…
932966f 
… r=jhpratt

Revert "Stabilize `str_as_str`"

Reverts rust-lang#151603, clean revert.
Fixes rust-lang#152961
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 22, 2026
@jhpratt
Rollup merge of rust-lang#152963 - JonathanBrouwer:revert-str-as-str,…
01008b3 
… r=jhpratt

Revert "Stabilize `str_as_str`"

Reverts rust-lang#151603, clean revert.
Fixes rust-lang#152961
Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 23, 2026
@Zalathar
Rollup merge of rust-lang#152963 - JonathanBrouwer:revert-str-as-str,…
867a480 
… r=jhpratt

Revert "Stabilize `str_as_str`"

Reverts rust-lang#151603, clean revert.
Fixes rust-lang#152961
niran added a commit to base/base that referenced this pull request Feb 23, 2026
@niran
fix(ci): pin udeps nightly to work around shellexpand breakage
da103bc 
nightly-2026-02-22+ includes the str::as_str() stabilization
(rust-lang/rust#151603) which shadows shellexpand 3.1.1's
WstrExt::as_str() trait method, causing a compile error.

Pin to nightly-2026-02-21 and invoke cargo-udeps directly since
`just check-udeps` hardcodes `cargo +nightly`.

Revert once rust-lang/rust#152963 lands in nightly.
@niran niran mentioned this pull request Feb 23, 2026
Merged
3 tasks
rust-timer added a commit that referenced this pull request Feb 23, 2026
@rust-timer
Unrolled build for #152963
734e274 
Rollup merge of #152963 - JonathanBrouwer:revert-str-as-str, r=jhpratt

Revert "Stabilize `str_as_str`"

Reverts #151603, clean revert.
Fixes #152961
github-merge-queue bot pushed a commit to base/base that referenced this pull request Feb 23, 2026
@niran
fix(ci): pin udeps nightly to work around shellexpand breakage (#827)
baa7466 
nightly-2026-02-22+ includes the str::as_str() stabilization
(rust-lang/rust#151603) which shadows shellexpand 3.1.1's
WstrExt::as_str() trait method, causing a compile error.

Pin to nightly-2026-02-21 and invoke cargo-udeps directly since
`just check-udeps` hardcodes `cargo +nightly`.

Revert once rust-lang/rust#152963 lands in nightly.
@niran niran mentioned this pull request Feb 23, 2026
Open
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Feb 24, 2026
@Zalathar
Rollup merge of #152963 - JonathanBrouwer:revert-str-as-str, r=jhpratt
fa962ab 
Revert "Stabilize `str_as_str`"

Reverts rust-lang/rust#151603, clean revert.
Fixes rust-lang/rust#152961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jhpratt jhpratt

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for str::as_str() & friends

6 participants

@GrigorenkoPV @rustbot @jhpratt @the8472 @rust-rfcbot @JonathanBrouwer