Skip to content

Add an additional help note to the ambiguity lint error#151198

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
weiznich:ambiguity_fix_help
Jan 16, 2026
Merged

Add an additional help note to the ambiguity lint error#151198
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
weiznich:ambiguity_fix_help

Conversation

@weiznich

@weiznich weiznich commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

This PR adds an additional help note to the ambiguity lint error output to ask users updating their dependencies. This hopefully helps with cases like #149845 where newer crate versions are fixed.

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 16, 2026
@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rustbot

rustbot commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Jan 16, 2026
@mati865

This comment was marked as resolved.

Comment thread compiler/rustc_resolve/src/diagnostics.rs Outdated
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2026
This PR adds an additional help note to the ambiguity lint error output
to ask users updating their dependencies. This hopefully helps with
cases like rust-lang#149845 where newer crate versions are fixed.
@weiznich

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2026
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-bors Bot commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d028956 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2026
rust-bors Bot pushed a commit that referenced this pull request Jan 16, 2026
Rollup of 4 pull requests

Successful merges:

 - #151196 (Ship LLVM (`rust-dev`) in fast try builds again)
 - #151198 (Add an additional help note to the ambiguity lint error)
 - #151215 (Add missing closing brackets to THIR output.)
 - #151218 (compiletest: Add `AuxCrate` struct with docs.)

r? @ghost
@rust-bors rust-bors Bot merged commit 64f318e into rust-lang:main Jan 16, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 16, 2026
rust-timer added a commit that referenced this pull request Jan 16, 2026
Rollup merge of #151198 - ambiguity_fix_help, r=petrochenkov

Add an additional help note to the ambiguity lint error

This PR adds an additional help note to the ambiguity lint error output to ask users updating their dependencies. This hopefully helps with cases like #149845 where newer crate versions are fixed.

r? @petrochenkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants